[GitHub] [airflow] kaxil commented on a change in pull request #18968: Suggestion to change DagRun.find in trigger_dag to use execution_date instead of run_id

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #18968:
URL: https://github.com/apache/airflow/pull/18968#discussion_r741490816



##########
File path: tests/models/test_dagrun.py
##########
@@ -142,6 +142,29 @@ def test_dagrun_find(self):
         assert 0 == len(models.DagRun.find(dag_id=dag_id2, external_trigger=True))
         assert 1 == len(models.DagRun.find(dag_id=dag_id2, external_trigger=False))
 
+    def test_dagrun_find_duplicate(self):
+        session = settings.Session()
+        now = timezone.utcnow()
+
+        dag_id1 = "test_dagrun_find_duplicate"

Review comment:
       ```suggestion
           dag_id = "test_dagrun_find_duplicate"
   ```
   
   nit: just a better variable name




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org