You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Flavio Percoco <fl...@gmail.com> on 2015/06/23 15:45:16 UTC
Review Request 35787: PROTON-490: skip missing environemnts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35787/
-----------------------------------------------------------
Review request for qpid and Kenneth Giusti.
Repository: qpid-proton-git
Description
-------
PROTON-490: skip missing environemnts
The drawback of this change is that we'll now depend on tox >= 1.7
Diffs
-----
proton-c/bindings/python/tox.ini aab5e4ea395958cd19d31a45e5dae0327694bd9c
Diff: https://reviews.apache.org/r/35787/diff/
Testing
-------
Thanks,
Flavio Percoco
Re: Review Request 35787: PROTON-490: skip missing environemnts
Posted by Gordon Sim <gs...@redhat.com>.
> On June 23, 2015, 6:07 p.m., Kenneth Giusti wrote:
> > I think we're stuck with two choices: leave tox 1.4 as the minimum and remove the 'py34' environment, OR use this patch.
> >
> > We'll want to test against py34, so that mandates this patch
And it is easy enough to install an updated tox (without needing suod/root), so I don't think requiring 1.7+ is a big downside. Ideally the build shouldn't fail without it - it should just not run the tox test (perhaps with a warning about the version)/
- Gordon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35787/#review89012
-----------------------------------------------------------
On June 23, 2015, 1:45 p.m., Flavio Percoco wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35787/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 1:45 p.m.)
>
>
> Review request for qpid and Kenneth Giusti.
>
>
> Repository: qpid-proton-git
>
>
> Description
> -------
>
> PROTON-490: skip missing environemnts
>
>
> The drawback of this change is that we'll now depend on tox >= 1.7
>
>
> Diffs
> -----
>
> proton-c/bindings/python/tox.ini aab5e4ea395958cd19d31a45e5dae0327694bd9c
>
> Diff: https://reviews.apache.org/r/35787/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Flavio Percoco
>
>
Re: Review Request 35787: PROTON-490: skip missing environemnts
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35787/#review89012
-----------------------------------------------------------
Ship it!
I think we're stuck with two choices: leave tox 1.4 as the minimum and remove the 'py34' environment, OR use this patch.
We'll want to test against py34, so that mandates this patch
- Kenneth Giusti
On June 23, 2015, 1:45 p.m., Flavio Percoco wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35787/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 1:45 p.m.)
>
>
> Review request for qpid and Kenneth Giusti.
>
>
> Repository: qpid-proton-git
>
>
> Description
> -------
>
> PROTON-490: skip missing environemnts
>
>
> The drawback of this change is that we'll now depend on tox >= 1.7
>
>
> Diffs
> -----
>
> proton-c/bindings/python/tox.ini aab5e4ea395958cd19d31a45e5dae0327694bd9c
>
> Diff: https://reviews.apache.org/r/35787/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Flavio Percoco
>
>