You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "David Boden (JIRA)" <ji...@codehaus.org> on 2006/01/06 11:48:02 UTC
[jira] Created: (MASSEMBLY-52) dependencySet is incorrect during
multi-module builds
dependencySet is incorrect during multi-module builds
-----------------------------------------------------
Key: MASSEMBLY-52
URL: http://jira.codehaus.org/browse/MASSEMBLY-52
Project: Maven 2.x Assembly Plugin
Type: Bug
Versions: 2.0
Environment: Windows XP, Java 1.5 (probably irrelevant)
Reporter: David Boden
Priority: Critical
When building using an aggregator pom (i.e. doing a multi module build) the assembly plugin resolves the project's dependencies incorrectly.
When you use the <dependencySet> function to assemble all the project's dependencies together, this problem results in a great deal of erroneous files being built into the assembly.
When I run mvn install on this single module only, the result is as I would expect.
When running in a multi-module build, the plugin is somehow picking up residual dependencies from other modules.
Assembly and pom XML follows:
<assembly>
<id>distribution</id>
<formats>
<format>zip</format>
</formats>
<includeBaseDirectory>false</includeBaseDirectory>
<fileSets>
<fileSet>
<directory>target</directory>
<includes>
<include>cds_adapter.jar</include>
</includes>
<outputDirectory>/lib</outputDirectory>
</fileSet>
<fileSet>
<directory>scripts</directory>
<outputDirectory>/scripts</outputDirectory>
</fileSet>
<fileSet>
<directory>scripts-win</directory>
<outputDirectory>/scripts-win</outputDirectory>
</fileSet>
<fileSet>
<directory>config</directory>
<outputDirectory>/config</outputDirectory>
</fileSet>
</fileSets>
<dependencySets>
<dependencySet>
<outputDirectory>/lib</outputDirectory>
<unpack>false</unpack>
<scope>runtime</scope>
</dependencySet>
</dependencySets>
</assembly>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<parent>
<groupId>SalesStation</groupId>
<artifactId>SSBuild</artifactId>
<version>SNAPSHOT</version>
<relativePath>../SSBuild/pom.xml</relativePath>
</parent>
<modelVersion>4.0.0</modelVersion>
<groupId>SalesStation</groupId>
<artifactId>cds_adapter</artifactId>
<packaging>jar</packaging>
<version>SNAPSHOT</version>
<name>SalesStation cds_adapter</name>
<build>
<finalName>cds_adapter</finalName>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<configuration>
<archive>
<manifest>
<addClasspath>true</addClasspath>
</manifest>
</archive>
</configuration>
</plugin>
<plugin>
<artifactId>maven-assembly-plugin</artifactId>
<executions>
<execution>
<phase>package</phase>
<goals>
<goal>assembly</goal>
</goals>
</execution>
</executions>
<configuration>
<descriptor>assembly.xml</descriptor>
</configuration>
</plugin>
</plugins>
</build>
<dependencies>
<dependency>
<groupId>com.tibco.Tibco</groupId>
<artifactId>tibrvj</artifactId>
<version>7.2</version>
<scope>system</scope>
<systemPath>${TIBCO_HOME}/lib/tibrvj.jar</systemPath>
</dependency>
<dependency>
<groupId>com.weblogic</groupId>
<artifactId>webserviceclient</artifactId>
<version>8.1</version>
<scope>system</scope>
<systemPath>${WEBLOGIC_HOME}/server/lib/webserviceclient.jar</systemPath>
</dependency>
<dependency>
<groupId>com.sybase</groupId>
<artifactId>jconnect</artifactId>
<version>5.5</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>javax.jms</groupId>
<artifactId>jms</artifactId>
<version>1.1</version>
</dependency>
<dependency>
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
<version>1.2.7</version>
</dependency>
<dependency>
<groupId>xerces</groupId>
<artifactId>xerces</artifactId>
<version>2.4.0</version>
</dependency>
<dependency>
<groupId>xalan</groupId>
<artifactId>xalan</artifactId>
<version>2.4.0</version>
</dependency>
<dependency>
<groupId>esm</groupId>
<artifactId>esm</artifactId>
<version>1.0</version>
</dependency>
<dependency>
<groupId>axis</groupId>
<artifactId>axis</artifactId>
<version>1.2.1</version>
</dependency>
<dependency>
<groupId>commons-collections</groupId>
<artifactId>commons-collections</artifactId>
<version>2.0</version>
</dependency>
<dependency>
<groupId>commons-dbcp</groupId>
<artifactId>commons-dbcp</artifactId>
<version>1.0</version>
</dependency>
</dependencies>
</project>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MASSEMBLY-52) dependencySet is incorrect during
multi-module builds
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-52?page=all ]
Brett Porter updated MASSEMBLY-52:
----------------------------------
Fix Version: 2.1
this is by design. We can add an optional to turn it off.
> dependencySet is incorrect during multi-module builds
> -----------------------------------------------------
>
> Key: MASSEMBLY-52
> URL: http://jira.codehaus.org/browse/MASSEMBLY-52
> Project: Maven 2.x Assembly Plugin
> Type: Bug
> Versions: 2.0
> Environment: Windows XP, Java 1.5 (probably irrelevant)
> Reporter: David Boden
> Priority: Critical
> Fix For: 2.1
>
>
> When building using an aggregator pom (i.e. doing a multi module build) the assembly plugin resolves the project's dependencies incorrectly.
> When you use the <dependencySet> function to assemble all the project's dependencies together, this problem results in a great deal of erroneous files being built into the assembly.
> When I run mvn install on this single module only, the result is as I would expect.
> When running in a multi-module build, the plugin is somehow picking up residual dependencies from other modules.
> Assembly and pom XML follows:
> <assembly>
> <id>distribution</id>
> <formats>
> <format>zip</format>
> </formats>
> <includeBaseDirectory>false</includeBaseDirectory>
> <fileSets>
> <fileSet>
> <directory>target</directory>
> <includes>
> <include>cds_adapter.jar</include>
> </includes>
> <outputDirectory>/lib</outputDirectory>
> </fileSet>
> <fileSet>
> <directory>scripts</directory>
> <outputDirectory>/scripts</outputDirectory>
> </fileSet>
> <fileSet>
> <directory>scripts-win</directory>
> <outputDirectory>/scripts-win</outputDirectory>
> </fileSet>
> <fileSet>
> <directory>config</directory>
> <outputDirectory>/config</outputDirectory>
> </fileSet>
> </fileSets>
> <dependencySets>
> <dependencySet>
> <outputDirectory>/lib</outputDirectory>
> <unpack>false</unpack>
> <scope>runtime</scope>
> </dependencySet>
> </dependencySets>
> </assembly>
> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
>
> <parent>
> <groupId>SalesStation</groupId>
> <artifactId>SSBuild</artifactId>
> <version>SNAPSHOT</version>
> <relativePath>../SSBuild/pom.xml</relativePath>
> </parent>
>
> <modelVersion>4.0.0</modelVersion>
> <groupId>SalesStation</groupId>
> <artifactId>cds_adapter</artifactId>
> <packaging>jar</packaging>
> <version>SNAPSHOT</version>
> <name>SalesStation cds_adapter</name>
>
> <build>
> <finalName>cds_adapter</finalName>
>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-jar-plugin</artifactId>
> <configuration>
> <archive>
> <manifest>
> <addClasspath>true</addClasspath>
> </manifest>
> </archive>
> </configuration>
> </plugin>
> <plugin>
> <artifactId>maven-assembly-plugin</artifactId>
> <executions>
> <execution>
> <phase>package</phase>
> <goals>
> <goal>assembly</goal>
> </goals>
> </execution>
> </executions>
> <configuration>
> <descriptor>assembly.xml</descriptor>
> </configuration>
> </plugin>
> </plugins>
> </build>
>
> <dependencies>
> <dependency>
> <groupId>com.tibco.Tibco</groupId>
> <artifactId>tibrvj</artifactId>
> <version>7.2</version>
> <scope>system</scope>
> <systemPath>${TIBCO_HOME}/lib/tibrvj.jar</systemPath>
> </dependency>
> <dependency>
> <groupId>com.weblogic</groupId>
> <artifactId>webserviceclient</artifactId>
> <version>8.1</version>
> <scope>system</scope>
> <systemPath>${WEBLOGIC_HOME}/server/lib/webserviceclient.jar</systemPath>
> </dependency>
>
> <dependency>
> <groupId>com.sybase</groupId>
> <artifactId>jconnect</artifactId>
> <version>5.5</version>
> <scope>runtime</scope>
> </dependency>
>
> <dependency>
> <groupId>javax.jms</groupId>
> <artifactId>jms</artifactId>
> <version>1.1</version>
> </dependency>
>
> <dependency>
> <groupId>log4j</groupId>
> <artifactId>log4j</artifactId>
> <version>1.2.7</version>
> </dependency>
> <dependency>
> <groupId>xerces</groupId>
> <artifactId>xerces</artifactId>
> <version>2.4.0</version>
> </dependency>
> <dependency>
> <groupId>xalan</groupId>
> <artifactId>xalan</artifactId>
> <version>2.4.0</version>
> </dependency>
> <dependency>
> <groupId>esm</groupId>
> <artifactId>esm</artifactId>
> <version>1.0</version>
> </dependency>
> <dependency>
> <groupId>axis</groupId>
> <artifactId>axis</artifactId>
> <version>1.2.1</version>
> </dependency>
> <dependency>
> <groupId>commons-collections</groupId>
> <artifactId>commons-collections</artifactId>
> <version>2.0</version>
> </dependency>
> <dependency>
> <groupId>commons-dbcp</groupId>
> <artifactId>commons-dbcp</artifactId>
> <version>1.0</version>
> </dependency>
> </dependencies>
> </project>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MASSEMBLY-52) dependencySet is incorrect during
multi-module builds
Posted by "David Boden (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-52?page=comments#action_55077 ]
David Boden commented on MASSEMBLY-52:
--------------------------------------
Thanks for the quick feedback.
I can't think of another example (that isn't a bug) of where a build behaves differently if you are building an individual module or multiple modules. I can't think of a scenario where I'd want the residual dependencies of other modules to be picked up. Could you provide an example scenario?
> dependencySet is incorrect during multi-module builds
> -----------------------------------------------------
>
> Key: MASSEMBLY-52
> URL: http://jira.codehaus.org/browse/MASSEMBLY-52
> Project: Maven 2.x Assembly Plugin
> Type: Bug
> Versions: 2.0
> Environment: Windows XP, Java 1.5 (probably irrelevant)
> Reporter: David Boden
> Priority: Critical
> Fix For: 2.1
>
>
> When building using an aggregator pom (i.e. doing a multi module build) the assembly plugin resolves the project's dependencies incorrectly.
> When you use the <dependencySet> function to assemble all the project's dependencies together, this problem results in a great deal of erroneous files being built into the assembly.
> When I run mvn install on this single module only, the result is as I would expect.
> When running in a multi-module build, the plugin is somehow picking up residual dependencies from other modules.
> Assembly and pom XML follows:
> <assembly>
> <id>distribution</id>
> <formats>
> <format>zip</format>
> </formats>
> <includeBaseDirectory>false</includeBaseDirectory>
> <fileSets>
> <fileSet>
> <directory>target</directory>
> <includes>
> <include>cds_adapter.jar</include>
> </includes>
> <outputDirectory>/lib</outputDirectory>
> </fileSet>
> <fileSet>
> <directory>scripts</directory>
> <outputDirectory>/scripts</outputDirectory>
> </fileSet>
> <fileSet>
> <directory>scripts-win</directory>
> <outputDirectory>/scripts-win</outputDirectory>
> </fileSet>
> <fileSet>
> <directory>config</directory>
> <outputDirectory>/config</outputDirectory>
> </fileSet>
> </fileSets>
> <dependencySets>
> <dependencySet>
> <outputDirectory>/lib</outputDirectory>
> <unpack>false</unpack>
> <scope>runtime</scope>
> </dependencySet>
> </dependencySets>
> </assembly>
> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
>
> <parent>
> <groupId>SalesStation</groupId>
> <artifactId>SSBuild</artifactId>
> <version>SNAPSHOT</version>
> <relativePath>../SSBuild/pom.xml</relativePath>
> </parent>
>
> <modelVersion>4.0.0</modelVersion>
> <groupId>SalesStation</groupId>
> <artifactId>cds_adapter</artifactId>
> <packaging>jar</packaging>
> <version>SNAPSHOT</version>
> <name>SalesStation cds_adapter</name>
>
> <build>
> <finalName>cds_adapter</finalName>
>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-jar-plugin</artifactId>
> <configuration>
> <archive>
> <manifest>
> <addClasspath>true</addClasspath>
> </manifest>
> </archive>
> </configuration>
> </plugin>
> <plugin>
> <artifactId>maven-assembly-plugin</artifactId>
> <executions>
> <execution>
> <phase>package</phase>
> <goals>
> <goal>assembly</goal>
> </goals>
> </execution>
> </executions>
> <configuration>
> <descriptor>assembly.xml</descriptor>
> </configuration>
> </plugin>
> </plugins>
> </build>
>
> <dependencies>
> <dependency>
> <groupId>com.tibco.Tibco</groupId>
> <artifactId>tibrvj</artifactId>
> <version>7.2</version>
> <scope>system</scope>
> <systemPath>${TIBCO_HOME}/lib/tibrvj.jar</systemPath>
> </dependency>
> <dependency>
> <groupId>com.weblogic</groupId>
> <artifactId>webserviceclient</artifactId>
> <version>8.1</version>
> <scope>system</scope>
> <systemPath>${WEBLOGIC_HOME}/server/lib/webserviceclient.jar</systemPath>
> </dependency>
>
> <dependency>
> <groupId>com.sybase</groupId>
> <artifactId>jconnect</artifactId>
> <version>5.5</version>
> <scope>runtime</scope>
> </dependency>
>
> <dependency>
> <groupId>javax.jms</groupId>
> <artifactId>jms</artifactId>
> <version>1.1</version>
> </dependency>
>
> <dependency>
> <groupId>log4j</groupId>
> <artifactId>log4j</artifactId>
> <version>1.2.7</version>
> </dependency>
> <dependency>
> <groupId>xerces</groupId>
> <artifactId>xerces</artifactId>
> <version>2.4.0</version>
> </dependency>
> <dependency>
> <groupId>xalan</groupId>
> <artifactId>xalan</artifactId>
> <version>2.4.0</version>
> </dependency>
> <dependency>
> <groupId>esm</groupId>
> <artifactId>esm</artifactId>
> <version>1.0</version>
> </dependency>
> <dependency>
> <groupId>axis</groupId>
> <artifactId>axis</artifactId>
> <version>1.2.1</version>
> </dependency>
> <dependency>
> <groupId>commons-collections</groupId>
> <artifactId>commons-collections</artifactId>
> <version>2.0</version>
> </dependency>
> <dependency>
> <groupId>commons-dbcp</groupId>
> <artifactId>commons-dbcp</artifactId>
> <version>1.0</version>
> </dependency>
> </dependencies>
> </project>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org