You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "VaishnaviR18 (via GitHub)" <gi...@apache.org> on 2023/06/30 15:22:11 UTC
[GitHub] [camel] VaishnaviR18 opened a new pull request, #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
VaishnaviR18 opened a new pull request, #10555:
URL: https://github.com/apache/camel/pull/10555
…rty.
# Description
<!--
- Added a kerberos config location parameter in camel-kafka component.
-->
# Target
- [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10555:
URL: https://github.com/apache/camel/pull/10555#issuecomment-1617864057
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 3 | 3 | 1 | 2 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] VaishnaviR18 commented on pull request #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
Posted by "VaishnaviR18 (via GitHub)" <gi...@apache.org>.
VaishnaviR18 commented on PR #10555:
URL: https://github.com/apache/camel/pull/10555#issuecomment-1615578292
Sure, i will update it. Thanks a lot!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10555:
URL: https://github.com/apache/camel/pull/10555#issuecomment-1625404457
:leftwards_arrow_with_hook: There are either **too many** changes to be tested in this PR or the code **needs be rebased**: (70 components likely to be affected)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10555:
URL: https://github.com/apache/camel/pull/10555#issuecomment-1620036705
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 10 | 10 | 3 | 6 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] VaishnaviR18 commented on a diff in pull request #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
Posted by "VaishnaviR18 (via GitHub)" <gi...@apache.org>.
VaishnaviR18 commented on code in PR #10555:
URL: https://github.com/apache/camel/pull/10555#discussion_r1255255005
##########
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaFetchRecords.java:
##########
@@ -244,6 +244,9 @@ protected void createConsumer() {
// this may throw an exception if something is wrong with kafka consumer
this.consumer = kafkaConsumer.getEndpoint().getKafkaClientFactory().getConsumer(kafkaProps);
+ var krbLocation = kafkaConsumer.getEndpoint().getConfiguration().getKerberosConfigLocation();
+ System.setProperty("java.security.krb5.conf", krbLocation);
Review Comment:
@davsclaus Yes correct, missed that point. Thanks!
As there is no default location, can we update the code like this?
var krbLocation = kafkaConsumer.getEndpoint().getConfiguration().getKerberosConfigLocation();
if (krbLocation != null) {
System.setProperty("java.security.krb5.conf", krbLocation);
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] VaishnaviR18 commented on pull request #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
Posted by "VaishnaviR18 (via GitHub)" <gi...@apache.org>.
VaishnaviR18 commented on PR #10555:
URL: https://github.com/apache/camel/pull/10555#issuecomment-1617394238
Updated the docs. Can anyone please review it?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] VaishnaviR18 commented on a diff in pull request #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
Posted by "VaishnaviR18 (via GitHub)" <gi...@apache.org>.
VaishnaviR18 commented on code in PR #10555:
URL: https://github.com/apache/camel/pull/10555#discussion_r1255350514
##########
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaFetchRecords.java:
##########
@@ -244,6 +244,9 @@ protected void createConsumer() {
// this may throw an exception if something is wrong with kafka consumer
this.consumer = kafkaConsumer.getEndpoint().getKafkaClientFactory().getConsumer(kafkaProps);
+ var krbLocation = kafkaConsumer.getEndpoint().getConfiguration().getKerberosConfigLocation();
+ System.setProperty("java.security.krb5.conf", krbLocation);
Review Comment:
Fixed this issue. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10555:
URL: https://github.com/apache/camel/pull/10555#issuecomment-1624925232
### Core test results:
| Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- |
| 1 | 1 | 0 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10555:
URL: https://github.com/apache/camel/pull/10555#issuecomment-1621486946
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 16 | 16 | 3 | 12 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10555:
URL: https://github.com/apache/camel/pull/10555#issuecomment-1624925178
:leftwards_arrow_with_hook: There are either **too many** changes to be tested in this PR or the code **needs be rebased**: (70 components likely to be affected)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10555:
URL: https://github.com/apache/camel/pull/10555#issuecomment-1618786113
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 3 | 3 | 1 | 2 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10555:
URL: https://github.com/apache/camel/pull/10555#issuecomment-1618786161
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a diff in pull request #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #10555:
URL: https://github.com/apache/camel/pull/10555#discussion_r1252656095
##########
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaFetchRecords.java:
##########
@@ -244,6 +244,9 @@ protected void createConsumer() {
// this may throw an exception if something is wrong with kafka consumer
this.consumer = kafkaConsumer.getEndpoint().getKafkaClientFactory().getConsumer(kafkaProps);
+ var krbLocation = kafkaConsumer.getEndpoint().getConfiguration().getKerberosConfigLocation();
+ System.setProperty("java.security.krb5.conf", krbLocation);
Review Comment:
What happens if this option is not set, then the value is null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10555:
URL: https://github.com/apache/camel/pull/10555#issuecomment-1614812209
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10555:
URL: https://github.com/apache/camel/pull/10555#issuecomment-1628417178
This is good to merge. Let's merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske merged pull request #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske merged PR #10555:
URL: https://github.com/apache/camel/pull/10555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10555:
URL: https://github.com/apache/camel/pull/10555#issuecomment-1621486983
### Core test results:
| Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- |
| 1 | 1 | 0 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10555:
URL: https://github.com/apache/camel/pull/10555#issuecomment-1620036732
### Core test results:
| Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- |
| 1 | 1 | 0 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a diff in pull request #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #10555:
URL: https://github.com/apache/camel/pull/10555#discussion_r1255290489
##########
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaFetchRecords.java:
##########
@@ -244,6 +244,9 @@ protected void createConsumer() {
// this may throw an exception if something is wrong with kafka consumer
this.consumer = kafkaConsumer.getEndpoint().getKafkaClientFactory().getConsumer(kafkaProps);
+ var krbLocation = kafkaConsumer.getEndpoint().getConfiguration().getKerberosConfigLocation();
+ System.setProperty("java.security.krb5.conf", krbLocation);
Review Comment:
Okay let us know when you have fixed this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10555:
URL: https://github.com/apache/camel/pull/10555#issuecomment-1617864123
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] VaishnaviR18 commented on pull request #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
Posted by "VaishnaviR18 (via GitHub)" <gi...@apache.org>.
VaishnaviR18 commented on PR #10555:
URL: https://github.com/apache/camel/pull/10555#issuecomment-1619556051
Added all the generated files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10555: [CAMEL-19412] - camel-kafka - Add kerberos config file location prope…
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10555:
URL: https://github.com/apache/camel/pull/10555#issuecomment-1625404485
### Core test results:
| Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- |
| 1 | 1 | 0 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org