You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/25 18:01:43 UTC

[GitHub] [skywalking] mikhail-dr opened a new issue #7569: [INFRA] Python's coding directive is not honored

mikhail-dr opened a new issue #7569:
URL: https://github.com/apache/skywalking/issues/7569


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [X ] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Question
   - What do you want to know?
   
   ___
   ### Bug
   
   When running the tool on a large number of Python files, we noticed that, if a Python file happens to have the `coding` directive, the tool seems unaware of it and inserts the copyright statement _before_ the `coding` directive, thereby pushing that `coding` directive further down in the Python file, which makes it useless. the `coding` directive must either be in the 1st or 2nd line of a Python file:
   
   ```
   # coding=utf-8
   ```
   
   You can find more information on the `coding` directive here: https://www.python.org/dev/peps/pep-0263/#defining-the-encoding, where there is an exact regexp as well. Thanks!
   
   
   - Which version of SkyWalking, OS, and JRE?
   
   - Which company or project?
   
   - What happened?
   If possible, provide a way to reproduce the error. e.g. demo application, component version.
   
   ___
   ### Requirement or improvement
   - Please describe your requirements or improvement suggestions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 closed issue #7569: [INFRA] Python's coding directive is not honored

Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed issue #7569:
URL: https://github.com/apache/skywalking/issues/7569


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org