You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/05/19 15:12:24 UTC

[GitHub] [tinkerpop] spmallette commented on a change in pull request #1287: Fix TINKERPOP-2371 Add possibility to import constants with ImportGremlinPlugin

spmallette commented on a change in pull request #1287:
URL: https://github.com/apache/tinkerpop/pull/1287#discussion_r427381517



##########
File path: gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/jsr223/ImportGremlinPluginTest.java
##########
@@ -24,13 +24,16 @@
 import org.apache.tinkerpop.gremlin.util.Gremlin;
 import org.junit.Test;
 
+import com.google.common.collect.ImmutableSet;
+
+import java.lang.reflect.Field;
 import java.lang.reflect.Method;
 import java.util.Collections;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
 import static org.hamcrest.MatcherAssert.assertThat;
-import static org.hamcrest.core.IsCollectionContaining.hasItems;
+import static org.hamcrest.Matchers.*;

Review comment:
       could you please remove the wildcard here (it's not our code style to allow that - all imports are explicit)? thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org