[GitHub] [skywalking-swck] dashanji commented on a change in pull request #30: add feature: java agent injector

[GitBox <gi...@apache.org>]

dashanji commented on a change in pull request #30:
URL: https://github.com/apache/skywalking-swck/pull/30#discussion_r708378507



##########
File path: pkg/operator/injector/injector.go
##########
@@ -293,6 +298,29 @@ func (s *SidecarInjectField) OverlayAgent(a Annotations, ao *AnnotationOverlay,
 	return true
 }
 
+// OverlayOptional overlays optional plugins and move optional plugins to the directory(/plugins)
+// user must ensure that the optional plugins are in the injected container's image
+// Notice , user must specify the optional plugins' version
+// such as spring-cloud-gateway-2.0.x or spring-cloud-gateway-2.1.x
+// the final command will be "mv /optional-plugins/*spring-cloud-gateway-2.0.x*  /plugins/"
+func (s *SidecarInjectField) OverlayOptional(annotation *map[string]string) {
+	sourcePath := strings.Join([]string{s.SidecarVolumeMount.MountPath, "optional-plugins/"}, "/")

Review comment:
       Ok，thanks for reminding




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org