[GitHub] [dolphinscheduler] DarkAssassinator commented on pull request #13002: [Improve-13001]migrate commons-collections -> commons-collections4

[GitBox <gi...@apache.org>]

DarkAssassinator commented on PR #13002:
URL: https://github.com/apache/dolphinscheduler/pull/13002#issuecomment-1327536979

   > commons-collections-3.2.2.jar
   
   
   
   > `commons-collections-3.2.2.jar` is still in dependency tree, can we totally remove this?
   
   after i check dependency tree, we can found that many 3rd jars depend `commons-collections`, please check the following some result:
   ```
   [INFO] org.apache.dolphinscheduler:dolphinscheduler-spi:jar:dev-SNAPSHOT
   [INFO] \- org.apache.dolphinscheduler:dolphinscheduler-common:jar:dev-SNAPSHOT:compile
   [INFO]    \- commons-beanutils:commons-beanutils:jar:1.9.4:compile
   [INFO]       \- commons-collections:commons-collections:jar:3.2.2:compile
   
   [INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ dolphinscheduler-service ---
   [INFO] Verbose not supported since maven-dependency-plugin 3.0
   [INFO] org.apache.dolphinscheduler:dolphinscheduler-service:jar:dev-SNAPSHOT
   [INFO] \- org.apache.hadoop:hadoop-common:jar:3.2.4:provided
   [INFO]    \- commons-collections:commons-collections:jar:3.2.2:compile
   ```
   And `commons-collections` and `commons-collections4` are diff artifactId, so we cannot remote `commons-collections-3.2.2.jar`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org