You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/29 17:51:29 UTC
[GitHub] MaxGekk commented on issue #23000: [SPARK-26002][SQL] Fix day of
year calculation for Julian calendar days
MaxGekk commented on issue #23000: [SPARK-26002][SQL] Fix day of year calculation for Julian calendar days
URL: https://github.com/apache/spark/pull/23000#issuecomment-450509114
@gatorsmile Thanx for the ping. Actually current implementation support [Proleptic Gregorian calendar](https://en.wikipedia.org/wiki/Proleptic_Gregorian_calendar) even if it is not documented explicitly. Recently we switched on [this chronology](https://github.com/apache/spark/pull/23358/files#diff-3e4b85f54d2e75f1b5b845279749024eR38) for parsing/formatting date/timestamps in JSON/CSV datasource (see #23150 and #23196) and in functions (see #23358).
If we support the hybrid calendar ([Julian](https://en.wikipedia.org/wiki/Julian_calendar) + [Gregorian](https://en.wikipedia.org/wiki/Gregorian_calendar)) here, it will introduce additional inconsistency.
@attilapiros If you need the hybrid calendar for some reasons, you should extend the `Year` expression by additional argument to set chronology (calendar system) otherwise you can break user's apps potentially.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org