You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Peter Schuller (JIRA)" <ji...@apache.org> on 2011/01/21 01:58:44 UTC
[jira] Created: (CASSANDRA-2023) fix regression in 1968 (young gen
sizing logic)
fix regression in 1968 (young gen sizing logic)
-----------------------------------------------
Key: CASSANDRA-2023
URL: https://issues.apache.org/jira/browse/CASSANDRA-2023
Project: Cassandra
Issue Type: Bug
Reporter: Peter Schuller
Assignee: Peter Schuller
Attachments: 2023.txt
1968 introduced a regression (there was still cleanup to do). In particular it broke when an explicit MAX_HEAP_SIZE was set. Attaching *draft* patch (needs more testing).
Allowing automatic newsize calculation in the face of a manually specified MAX_HEAP_SIZE was problematic. Either one has to duplicate JVM parsing of MAX_HEAP_SIZE or ask the user to set MAX_HEAP_SIZE_IN_MB (or similar) instead.
In this patch (consider it a draft) i opted for the latter + picking up MAX_HEAP_SIZE for backwards compatibility (but with the effect that it disables new size calculation). I tried to make it slightly more posixly correct, but as usual no guarantees given that I have no posix shell to test it on.
I'm not really happy about the shell acrobatics and my confidence that there is not some left-over issue is not high. Should we just not worry about MAX_HEAP_SIZE compatibility and remove all that compatibility cruft? Plenty of acrobatics left still, but it would remove the more hideous parts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-2023) fix regression in 1968 (young gen
sizing logic)
Posted by "Peter Schuller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Schuller updated CASSANDRA-2023:
--------------------------------------
Attachment: 2023-v2.txt
v2 is significantly simpler and cleaner (IMO). Tested on MacOS and Linux.
FWIW, the reason I didn't do "must set both" initially is that I felt the new size was a lot more obscure/advanced than merely setting heap size. v2 tries to mitigate this by documenting what to do if unsure/don't care.
> fix regression in 1968 (young gen sizing logic)
> -----------------------------------------------
>
> Key: CASSANDRA-2023
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2023
> Project: Cassandra
> Issue Type: Bug
> Reporter: Peter Schuller
> Assignee: Peter Schuller
> Attachments: 2023-v2.txt, 2023.txt
>
>
> 1968 introduced a regression (there was still cleanup to do). In particular it broke when an explicit MAX_HEAP_SIZE was set. Attaching *draft* patch (needs more testing).
> Allowing automatic newsize calculation in the face of a manually specified MAX_HEAP_SIZE was problematic. Either one has to duplicate JVM parsing of MAX_HEAP_SIZE or ask the user to set MAX_HEAP_SIZE_IN_MB (or similar) instead.
> In this patch (consider it a draft) i opted for the latter + picking up MAX_HEAP_SIZE for backwards compatibility (but with the effect that it disables new size calculation). I tried to make it slightly more posixly correct, but as usual no guarantees given that I have no posix shell to test it on.
> I'm not really happy about the shell acrobatics and my confidence that there is not some left-over issue is not high. Should we just not worry about MAX_HEAP_SIZE compatibility and remove all that compatibility cruft? Plenty of acrobatics left still, but it would remove the more hideous parts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-2023) fix regression in 1968 (young
gen sizing logic)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985951#action_12985951 ]
Hudson commented on CASSANDRA-2023:
-----------------------------------
Integrated in Cassandra-0.7 #199 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/199/])
fix young gen sizing logic
Patch by Peter Shuller (w/ minor changes); review by eevans for CASSANDRA-2023
> fix regression in 1968 (young gen sizing logic)
> -----------------------------------------------
>
> Key: CASSANDRA-2023
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2023
> Project: Cassandra
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 0.7.1
> Reporter: Peter Schuller
> Assignee: Peter Schuller
> Fix For: 0.7.1
>
> Attachments: 2023-v2.txt, 2023.txt
>
>
> 1968 introduced a regression (there was still cleanup to do). In particular it broke when an explicit MAX_HEAP_SIZE was set. Attaching *draft* patch (needs more testing).
> Allowing automatic newsize calculation in the face of a manually specified MAX_HEAP_SIZE was problematic. Either one has to duplicate JVM parsing of MAX_HEAP_SIZE or ask the user to set MAX_HEAP_SIZE_IN_MB (or similar) instead.
> In this patch (consider it a draft) i opted for the latter + picking up MAX_HEAP_SIZE for backwards compatibility (but with the effect that it disables new size calculation). I tried to make it slightly more posixly correct, but as usual no guarantees given that I have no posix shell to test it on.
> I'm not really happy about the shell acrobatics and my confidence that there is not some left-over issue is not high. Should we just not worry about MAX_HEAP_SIZE compatibility and remove all that compatibility cruft? Plenty of acrobatics left still, but it would remove the more hideous parts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-2023) fix regression in 1968 (young gen
sizing logic)
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans resolved CASSANDRA-2023.
-----------------------------------
Resolution: Fixed
Please avoid making unrelated changes to whitespace/styling as it makes review more difficult. Otherwise, it looks good.
Committed.
> fix regression in 1968 (young gen sizing logic)
> -----------------------------------------------
>
> Key: CASSANDRA-2023
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2023
> Project: Cassandra
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 0.7.1
> Reporter: Peter Schuller
> Assignee: Peter Schuller
> Fix For: 0.7.1
>
> Attachments: 2023-v2.txt, 2023.txt
>
>
> 1968 introduced a regression (there was still cleanup to do). In particular it broke when an explicit MAX_HEAP_SIZE was set. Attaching *draft* patch (needs more testing).
> Allowing automatic newsize calculation in the face of a manually specified MAX_HEAP_SIZE was problematic. Either one has to duplicate JVM parsing of MAX_HEAP_SIZE or ask the user to set MAX_HEAP_SIZE_IN_MB (or similar) instead.
> In this patch (consider it a draft) i opted for the latter + picking up MAX_HEAP_SIZE for backwards compatibility (but with the effect that it disables new size calculation). I tried to make it slightly more posixly correct, but as usual no guarantees given that I have no posix shell to test it on.
> I'm not really happy about the shell acrobatics and my confidence that there is not some left-over issue is not high. Should we just not worry about MAX_HEAP_SIZE compatibility and remove all that compatibility cruft? Plenty of acrobatics left still, but it would remove the more hideous parts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-2023) fix regression in 1968 (young gen
sizing logic)
Posted by "Peter Schuller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Schuller updated CASSANDRA-2023:
--------------------------------------
Attachment: 2023.txt
> fix regression in 1968 (young gen sizing logic)
> -----------------------------------------------
>
> Key: CASSANDRA-2023
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2023
> Project: Cassandra
> Issue Type: Bug
> Reporter: Peter Schuller
> Assignee: Peter Schuller
> Attachments: 2023.txt
>
>
> 1968 introduced a regression (there was still cleanup to do). In particular it broke when an explicit MAX_HEAP_SIZE was set. Attaching *draft* patch (needs more testing).
> Allowing automatic newsize calculation in the face of a manually specified MAX_HEAP_SIZE was problematic. Either one has to duplicate JVM parsing of MAX_HEAP_SIZE or ask the user to set MAX_HEAP_SIZE_IN_MB (or similar) instead.
> In this patch (consider it a draft) i opted for the latter + picking up MAX_HEAP_SIZE for backwards compatibility (but with the effect that it disables new size calculation). I tried to make it slightly more posixly correct, but as usual no guarantees given that I have no posix shell to test it on.
> I'm not really happy about the shell acrobatics and my confidence that there is not some left-over issue is not high. Should we just not worry about MAX_HEAP_SIZE compatibility and remove all that compatibility cruft? Plenty of acrobatics left still, but it would remove the more hideous parts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-2023) fix regression in 1968 (young
gen sizing logic)
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984549#action_12984549 ]
Jonathan Ellis commented on CASSANDRA-2023:
-------------------------------------------
bq. automatic newsize calculation in the face of a manually specified MAX_HEAP_SIZE was problematic. Either one has to duplicate JVM parsing of MAX_HEAP_SIZE or ask the user to set MAX_HEAP_SIZE_IN_MB (or similar) instead.
I would rather say "if you manually specify MAX_HEAP_SIZE, you must also specify HEAP_NEWSIZE."
> fix regression in 1968 (young gen sizing logic)
> -----------------------------------------------
>
> Key: CASSANDRA-2023
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2023
> Project: Cassandra
> Issue Type: Bug
> Reporter: Peter Schuller
> Assignee: Peter Schuller
> Attachments: 2023.txt
>
>
> 1968 introduced a regression (there was still cleanup to do). In particular it broke when an explicit MAX_HEAP_SIZE was set. Attaching *draft* patch (needs more testing).
> Allowing automatic newsize calculation in the face of a manually specified MAX_HEAP_SIZE was problematic. Either one has to duplicate JVM parsing of MAX_HEAP_SIZE or ask the user to set MAX_HEAP_SIZE_IN_MB (or similar) instead.
> In this patch (consider it a draft) i opted for the latter + picking up MAX_HEAP_SIZE for backwards compatibility (but with the effect that it disables new size calculation). I tried to make it slightly more posixly correct, but as usual no guarantees given that I have no posix shell to test it on.
> I'm not really happy about the shell acrobatics and my confidence that there is not some left-over issue is not high. Should we just not worry about MAX_HEAP_SIZE compatibility and remove all that compatibility cruft? Plenty of acrobatics left still, but it would remove the more hideous parts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-2023) fix regression in 1968 (young gen
sizing logic)
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2023:
--------------------------------------
Reviewer: urandom
Component/s: Packaging
Affects Version/s: 0.7.1
Fix Version/s: (was: 0.7.2)
0.7.1
> fix regression in 1968 (young gen sizing logic)
> -----------------------------------------------
>
> Key: CASSANDRA-2023
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2023
> Project: Cassandra
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 0.7.1
> Reporter: Peter Schuller
> Assignee: Peter Schuller
> Fix For: 0.7.1
>
> Attachments: 2023-v2.txt, 2023.txt
>
>
> 1968 introduced a regression (there was still cleanup to do). In particular it broke when an explicit MAX_HEAP_SIZE was set. Attaching *draft* patch (needs more testing).
> Allowing automatic newsize calculation in the face of a manually specified MAX_HEAP_SIZE was problematic. Either one has to duplicate JVM parsing of MAX_HEAP_SIZE or ask the user to set MAX_HEAP_SIZE_IN_MB (or similar) instead.
> In this patch (consider it a draft) i opted for the latter + picking up MAX_HEAP_SIZE for backwards compatibility (but with the effect that it disables new size calculation). I tried to make it slightly more posixly correct, but as usual no guarantees given that I have no posix shell to test it on.
> I'm not really happy about the shell acrobatics and my confidence that there is not some left-over issue is not high. Should we just not worry about MAX_HEAP_SIZE compatibility and remove all that compatibility cruft? Plenty of acrobatics left still, but it would remove the more hideous parts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-2023) fix regression in 1968 (young
gen sizing logic)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985966#action_12985966 ]
Hudson commented on CASSANDRA-2023:
-----------------------------------
Integrated in Cassandra #687 (See [https://hudson.apache.org/hudson/job/Cassandra/687/])
fix young gen sizing logic
Patch by Peter Shuller (w/ minor changes); review by eevans for CASSANDRA-2023
> fix regression in 1968 (young gen sizing logic)
> -----------------------------------------------
>
> Key: CASSANDRA-2023
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2023
> Project: Cassandra
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 0.7.1
> Reporter: Peter Schuller
> Assignee: Peter Schuller
> Fix For: 0.7.1
>
> Attachments: 2023-v2.txt, 2023.txt
>
>
> 1968 introduced a regression (there was still cleanup to do). In particular it broke when an explicit MAX_HEAP_SIZE was set. Attaching *draft* patch (needs more testing).
> Allowing automatic newsize calculation in the face of a manually specified MAX_HEAP_SIZE was problematic. Either one has to duplicate JVM parsing of MAX_HEAP_SIZE or ask the user to set MAX_HEAP_SIZE_IN_MB (or similar) instead.
> In this patch (consider it a draft) i opted for the latter + picking up MAX_HEAP_SIZE for backwards compatibility (but with the effect that it disables new size calculation). I tried to make it slightly more posixly correct, but as usual no guarantees given that I have no posix shell to test it on.
> I'm not really happy about the shell acrobatics and my confidence that there is not some left-over issue is not high. Should we just not worry about MAX_HEAP_SIZE compatibility and remove all that compatibility cruft? Plenty of acrobatics left still, but it would remove the more hideous parts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.