You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/22 12:10:59 UTC
[GitHub] [arrow-datafusion] tustvold opened a new issue, #4325: Potential MemoryManager Deadlock
tustvold opened a new issue, #4325:
URL: https://github.com/apache/arrow-datafusion/issues/4325
**Describe the bug**
`MemoryManager::can_grow_directly` makes use of a `parking_lot::CondVar`. This is a blocking primitive, and as a result will block the current tokio worker thread until such a time as the condition is signalled.
As the tokio worker pool is a bounded thread pool, often with workers equal to the number of threads, this can potentially result in a deadlock where all the worker threads are blocked waiting for memory that will never be freed as all the workers are blocked.
**To Reproduce**
**Expected behavior**
It should be a simple case of switching to using https://docs.rs/tokio/latest/tokio/sync/struct.Notify.html instead of a `CondVar`
**Additional context**
Add any other context about the problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed issue #4325: Potential MemoryManager Deadlock
Posted by GitBox <gi...@apache.org>.
alamb closed issue #4325: Potential MemoryManager Deadlock
URL: https://github.com/apache/arrow-datafusion/issues/4325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #4325: Potential MemoryManager Deadlock
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #4325:
URL: https://github.com/apache/arrow-datafusion/issues/4325#issuecomment-1357763546
I think this is done via https://github.com/apache/arrow-datafusion/pull/4522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org