You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/05/19 00:25:41 UTC
[GitHub] [superset] codecov[bot] commented on pull request #24127: chore: Embrace the walrus operator
codecov[bot] commented on PR #24127:
URL: https://github.com/apache/superset/pull/24127#issuecomment-1553846198
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24127?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24127](https://app.codecov.io/gh/apache/superset/pull/24127?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7cdccf7) into [master](https://app.codecov.io/gh/apache/superset/commit/2222073778b0cee193f34c2500f2c489bb2a4bbe?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2222073) will **decrease** coverage by `11.33%`.
> The diff coverage is `30.00%`.
> :exclamation: Current head 7cdccf7 differs from pull request most recent head 26c722a. Consider uploading reports for the commit 26c722a to get more accurate results
```diff
@@ Coverage Diff @@
## master #24127 +/- ##
===========================================
- Coverage 68.30% 56.97% -11.33%
===========================================
Files 1952 1952
Lines 75432 75350 -82
Branches 8191 8189 -2
===========================================
- Hits 51521 42932 -8589
- Misses 21807 30315 +8508
+ Partials 2104 2103 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.16% <25.00%> (+0.06%)` | :arrow_up: |
| python | `59.40% <30.00%> (-23.41%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `53.18% <12.50%> (+0.08%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...set-ui-core/src/ui-overrides/ExtensionsRegistry.ts](https://app.codecov.io/gh/apache/superset/pull/24127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdWktb3ZlcnJpZGVzL0V4dGVuc2lvbnNSZWdpc3RyeS50cw==) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/components/TableSelector/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `81.08% <ø> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://app.codecov.io/gh/apache/superset/pull/24127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `63.63% <ø> (-0.65%)` | :arrow_down: |
| [.../features/databases/DatabaseModal/ExtraOptions.tsx](https://app.codecov.io/gh/apache/superset/pull/24127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2RhdGFiYXNlcy9EYXRhYmFzZU1vZGFsL0V4dHJhT3B0aW9ucy50c3g=) | `70.37% <ø> (ø)` | |
| [...end/src/features/databases/DatabaseModal/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2RhdGFiYXNlcy9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `45.36% <ø> (ø)` | |
| [...end/src/features/databases/DatabaseModal/styles.ts](https://app.codecov.io/gh/apache/superset/pull/24127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2RhdGFiYXNlcy9EYXRhYmFzZU1vZGFsL3N0eWxlcy50cw==) | `77.66% <ø> (ø)` | |
| [superset-frontend/src/pages/DatabaseList/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0RhdGFiYXNlTGlzdC9pbmRleC50c3g=) | `66.66% <ø> (+0.62%)` | :arrow_up: |
| [superset-frontend/src/pages/DatasetList/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0RhdGFzZXRMaXN0L2luZGV4LnRzeA==) | `57.59% <ø> (ø)` | |
| [superset/charts/api.py](https://app.codecov.io/gh/apache/superset/pull/24127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `50.99% <0.00%> (-34.87%)` | :arrow_down: |
| [superset/charts/commands/bulk\_delete.py](https://app.codecov.io/gh/apache/superset/pull/24127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2J1bGtfZGVsZXRlLnB5) | `45.71% <0.00%> (-45.96%)` | :arrow_down: |
| ... and [45 more](https://app.codecov.io/gh/apache/superset/pull/24127?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [265 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24127/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org