[GitHub] [james-project] chibenwa commented on a change in pull request #860: JAMES-3708 Invalid mail address: Demonstrate NPE in RemoteDelivery

[GitBox <gi...@apache.org>]

chibenwa commented on a change in pull request #860:
URL: https://github.com/apache/james-project/pull/860#discussion_r793649199



##########
File path: core/src/test/java/org/apache/james/core/MailAddressTest.java
##########
@@ -47,6 +48,7 @@
                 GOOD_ADDRESS,
                 GOOD_QUOTED_LOCAL_PART,
                 "server-dev@james-apache.org",
+                "a..b@domain.com",

Review comment:
       Yes I know. Sorry it is indeed misleading.
   
   > (but maybe that's on purpose to demonstrate the issue ?)
   
   Yes it is, as my fix suggests to move it to bad address/




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org