[GitHub] [incubator-linkis] husofskyzy commented on pull request #1736: Dev 1.2.0 Add junit5 test code for [linkis-common]

[GitBox <gi...@apache.org>]

husofskyzy commented on pull request #1736:
URL: https://github.com/apache/incubator-linkis/pull/1736#issuecomment-1069821971


   plz put the test code to dev1.1.1 branch and make sure it can get through Packaging process，we would not like there to be try catch in the code,so maybe you can change the code style such as
   @Test(expected= IndexOutOfBoundsException.class)
   public void empty() {
   new ArrayList<Object>().get(0);
   }
   
   
   
   At 2022-03-16 11:41:53, "めぐみん" ***@***.***> wrote:
   
   @husofskyzy Could u plz review the code and give me some advice so I can improve myself and move on to the rest of the work?
   
   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   Triage notifications on the go with GitHub Mobile for iOS or Android.
   You are receiving this because you were mentioned.Message ID: ***@***.***>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org