You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@teaclave.apache.org by "henrysun007 (via GitHub)" <gi...@apache.org> on 2023/04/25 08:22:23 UTC
[GitHub] [incubator-teaclave] henrysun007 opened a new pull request, #689: Apache compliance
henrysun007 opened a new pull request, #689:
URL: https://github.com/apache/incubator-teaclave/pull/689
## Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Adjust according to IPMC advice (https://lists.apache.org/thread/6xbzdbrcd35drh7315mcsp8ko49mlx23).
Fixes #683
## Type of change (select or add applied and delete the others)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] API change with a documentation update
- [ ] Additional test coverage
- [X] Code cleanup or just sync with upstream third-party crates
## How has this been tested?
## Checklist
- [X] Fork the repo and create your branch from `master`.
- [ ] If you've added code that should be tested, add tests.
- [ ] If you've changed APIs, update the documentation.
- [X] Ensure the tests pass (see CI results).
- [X] Make sure your code lints/format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] henrysun007 merged pull request #689: Apache compliance
Posted by "henrysun007 (via GitHub)" <gi...@apache.org>.
henrysun007 merged PR #689:
URL: https://github.com/apache/incubator-teaclave/pull/689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] qinkunbao commented on a diff in pull request #689: Apache compliance
Posted by "qinkunbao (via GitHub)" <gi...@apache.org>.
qinkunbao commented on code in PR #689:
URL: https://github.com/apache/incubator-teaclave/pull/689#discussion_r1186395520
##########
third_party/wamr.patch:
##########
Review Comment:
What is the reason of including this patch in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] henrysun007 commented on a diff in pull request #689: Apache compliance
Posted by "henrysun007 (via GitHub)" <gi...@apache.org>.
henrysun007 commented on code in PR #689:
URL: https://github.com/apache/incubator-teaclave/pull/689#discussion_r1186646031
##########
third_party/wamr.patch:
##########
Review Comment:
The patch is for running [wamr](https://github.com/bytecodealliance/wasm-micro-runtime) in teaclave originally. I modified it to remove unnessary `.wasm` files from the [source code](https://github.com/apache/incubator-teaclave/releases/download/v0.5.0/apache-teaclave-0.5.0-incubating.tar.gz) for release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] henrysun007 commented on a diff in pull request #689: Apache compliance
Posted by "henrysun007 (via GitHub)" <gi...@apache.org>.
henrysun007 commented on code in PR #689:
URL: https://github.com/apache/incubator-teaclave/pull/689#discussion_r1186646031
##########
third_party/wamr.patch:
##########
Review Comment:
The patch is for running [wamr](https://github.com/bytecodealliance/wasm-micro-runtime) in teaclave originally. I modified it to remove unnecessary `.wasm` files from the [source code](https://github.com/apache/incubator-teaclave/releases/download/v0.5.0/apache-teaclave-0.5.0-incubating.tar.gz) for release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org