You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Paul Brett <pa...@twopensource.com> on 2015/06/24 22:15:29 UTC
Review Request 35841: Fix usage of ATOMIC_FLAG_INIT
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Bernd Mathiske, Chi Zhang, Ian Downes, Jie Yu, Joris Van Remoortere, Vinod Kone, and Cong Wang.
Bugs: MESOS-2925
https://issues.apache.org/jira/browse/MESOS-2925
Repository: mesos
Description
-------
Fix usage of ATOMIC_FLAG_INIT
Diffs
-----
3rdparty/libprocess/include/process/future.hpp b20eb0683c6c4491eabaada46ae8d35d8a89ebaf
3rdparty/libprocess/include/process/http.hpp e47cc7afbc8110759edf25a2dc05d09eda25c417
3rdparty/libprocess/include/process/metrics/metric.hpp 44a7d5a272f5e5e86634c12b1003049ba0e4f932
3rdparty/libprocess/include/process/metrics/timer.hpp fd7b2db15f596b192f64658fae846b3899e8d1d0
3rdparty/libprocess/include/process/mutex.hpp 8fff089e2654bf1a5ac3cfec91def7688e0009ca
3rdparty/libprocess/include/process/queue.hpp 1496b3850648957ff34bf2bbe240d1ab0888c6f8
Diff: https://reviews.apache.org/r/35841/diff/
Testing
-------
sudo make check
Thanks,
Paul Brett
Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/#review89245
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On June 24, 2015, 8:15 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35841/
> -----------------------------------------------------------
>
> (Updated June 24, 2015, 8:15 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Chi Zhang, Ian Downes, Jie Yu, Joris Van Remoortere, Vinod Kone, and Cong Wang.
>
>
> Bugs: MESOS-2925
> https://issues.apache.org/jira/browse/MESOS-2925
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix usage of ATOMIC_FLAG_INIT
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/future.hpp b20eb0683c6c4491eabaada46ae8d35d8a89ebaf
> 3rdparty/libprocess/include/process/http.hpp e47cc7afbc8110759edf25a2dc05d09eda25c417
> 3rdparty/libprocess/include/process/metrics/metric.hpp 44a7d5a272f5e5e86634c12b1003049ba0e4f932
> 3rdparty/libprocess/include/process/metrics/timer.hpp fd7b2db15f596b192f64658fae846b3899e8d1d0
> 3rdparty/libprocess/include/process/mutex.hpp 8fff089e2654bf1a5ac3cfec91def7688e0009ca
> 3rdparty/libprocess/include/process/queue.hpp 1496b3850648957ff34bf2bbe240d1ab0888c6f8
>
> Diff: https://reviews.apache.org/r/35841/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/#review89310
-----------------------------------------------------------
Ship it!
Sweetness! Thanks for that :)
3rdparty/libprocess/include/process/metrics/timer.hpp (line 92)
<https://reviews.apache.org/r/35841/#comment141896>
Let's go with `Data() = default;` now.
3rdparty/libprocess/include/process/queue.hpp (line 63)
<https://reviews.apache.org/r/35841/#comment141895>
Let's go with `Data() = default;` now.
- Michael Park
On June 25, 2015, 3:55 a.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35841/
> -----------------------------------------------------------
>
> (Updated June 25, 2015, 3:55 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Chi Zhang, Ian Downes, Jie Yu, Joris Van Remoortere, Vinod Kone, and Cong Wang.
>
>
> Bugs: MESOS-2925
> https://issues.apache.org/jira/browse/MESOS-2925
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix usage of ATOMIC_FLAG_INIT
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/future.hpp b20eb0683c6c4491eabaada46ae8d35d8a89ebaf
> 3rdparty/libprocess/include/process/http.hpp e47cc7afbc8110759edf25a2dc05d09eda25c417
> 3rdparty/libprocess/include/process/metrics/metric.hpp 44a7d5a272f5e5e86634c12b1003049ba0e4f932
> 3rdparty/libprocess/include/process/metrics/timer.hpp fd7b2db15f596b192f64658fae846b3899e8d1d0
> 3rdparty/libprocess/include/process/mutex.hpp 8fff089e2654bf1a5ac3cfec91def7688e0009ca
> 3rdparty/libprocess/include/process/queue.hpp 1496b3850648957ff34bf2bbe240d1ab0888c6f8
> 3rdparty/libprocess/src/libevent_ssl_socket.hpp d65638b1dc1330c6393dc79efc7226dc9560c3b0
>
> Diff: https://reviews.apache.org/r/35841/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/#review89415
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On June 25, 2015, 5:27 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35841/
> -----------------------------------------------------------
>
> (Updated June 25, 2015, 5:27 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Chi Zhang, Ian Downes, Jie Yu, Joris Van Remoortere, Vinod Kone, and Cong Wang.
>
>
> Bugs: MESOS-2925
> https://issues.apache.org/jira/browse/MESOS-2925
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix usage of ATOMIC_FLAG_INIT
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/future.hpp b20eb0683c6c4491eabaada46ae8d35d8a89ebaf
> 3rdparty/libprocess/include/process/http.hpp e47cc7afbc8110759edf25a2dc05d09eda25c417
> 3rdparty/libprocess/include/process/metrics/metric.hpp 44a7d5a272f5e5e86634c12b1003049ba0e4f932
> 3rdparty/libprocess/include/process/metrics/timer.hpp fd7b2db15f596b192f64658fae846b3899e8d1d0
> 3rdparty/libprocess/include/process/mutex.hpp 8fff089e2654bf1a5ac3cfec91def7688e0009ca
> 3rdparty/libprocess/include/process/queue.hpp 1496b3850648957ff34bf2bbe240d1ab0888c6f8
> 3rdparty/libprocess/src/libevent_ssl_socket.hpp d65638b1dc1330c6393dc79efc7226dc9560c3b0
>
> Diff: https://reviews.apache.org/r/35841/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/#review89396
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35841]
All tests passed.
- Mesos ReviewBot
On June 25, 2015, 5:27 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35841/
> -----------------------------------------------------------
>
> (Updated June 25, 2015, 5:27 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Chi Zhang, Ian Downes, Jie Yu, Joris Van Remoortere, Vinod Kone, and Cong Wang.
>
>
> Bugs: MESOS-2925
> https://issues.apache.org/jira/browse/MESOS-2925
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix usage of ATOMIC_FLAG_INIT
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/future.hpp b20eb0683c6c4491eabaada46ae8d35d8a89ebaf
> 3rdparty/libprocess/include/process/http.hpp e47cc7afbc8110759edf25a2dc05d09eda25c417
> 3rdparty/libprocess/include/process/metrics/metric.hpp 44a7d5a272f5e5e86634c12b1003049ba0e4f932
> 3rdparty/libprocess/include/process/metrics/timer.hpp fd7b2db15f596b192f64658fae846b3899e8d1d0
> 3rdparty/libprocess/include/process/mutex.hpp 8fff089e2654bf1a5ac3cfec91def7688e0009ca
> 3rdparty/libprocess/include/process/queue.hpp 1496b3850648957ff34bf2bbe240d1ab0888c6f8
> 3rdparty/libprocess/src/libevent_ssl_socket.hpp d65638b1dc1330c6393dc79efc7226dc9560c3b0
>
> Diff: https://reviews.apache.org/r/35841/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/#review89416
-----------------------------------------------------------
Ship it!
Thank you Paul, Mpark for cleaning this up. This accomplished both the goal of conforming to the standard as well as maintaining readability!
- Joris Van Remoortere
On June 25, 2015, 5:27 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35841/
> -----------------------------------------------------------
>
> (Updated June 25, 2015, 5:27 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Chi Zhang, Ian Downes, Jie Yu, Joris Van Remoortere, Vinod Kone, and Cong Wang.
>
>
> Bugs: MESOS-2925
> https://issues.apache.org/jira/browse/MESOS-2925
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix usage of ATOMIC_FLAG_INIT
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/future.hpp b20eb0683c6c4491eabaada46ae8d35d8a89ebaf
> 3rdparty/libprocess/include/process/http.hpp e47cc7afbc8110759edf25a2dc05d09eda25c417
> 3rdparty/libprocess/include/process/metrics/metric.hpp 44a7d5a272f5e5e86634c12b1003049ba0e4f932
> 3rdparty/libprocess/include/process/metrics/timer.hpp fd7b2db15f596b192f64658fae846b3899e8d1d0
> 3rdparty/libprocess/include/process/mutex.hpp 8fff089e2654bf1a5ac3cfec91def7688e0009ca
> 3rdparty/libprocess/include/process/queue.hpp 1496b3850648957ff34bf2bbe240d1ab0888c6f8
> 3rdparty/libprocess/src/libevent_ssl_socket.hpp d65638b1dc1330c6393dc79efc7226dc9560c3b0
>
> Diff: https://reviews.apache.org/r/35841/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/
-----------------------------------------------------------
(Updated June 25, 2015, 5:27 p.m.)
Review request for mesos, Benjamin Hindman, Bernd Mathiske, Chi Zhang, Ian Downes, Jie Yu, Joris Van Remoortere, Vinod Kone, and Cong Wang.
Changes
-------
Rebase
Bugs: MESOS-2925
https://issues.apache.org/jira/browse/MESOS-2925
Repository: mesos
Description
-------
Fix usage of ATOMIC_FLAG_INIT
Diffs (updated)
-----
3rdparty/libprocess/include/process/future.hpp b20eb0683c6c4491eabaada46ae8d35d8a89ebaf
3rdparty/libprocess/include/process/http.hpp e47cc7afbc8110759edf25a2dc05d09eda25c417
3rdparty/libprocess/include/process/metrics/metric.hpp 44a7d5a272f5e5e86634c12b1003049ba0e4f932
3rdparty/libprocess/include/process/metrics/timer.hpp fd7b2db15f596b192f64658fae846b3899e8d1d0
3rdparty/libprocess/include/process/mutex.hpp 8fff089e2654bf1a5ac3cfec91def7688e0009ca
3rdparty/libprocess/include/process/queue.hpp 1496b3850648957ff34bf2bbe240d1ab0888c6f8
3rdparty/libprocess/src/libevent_ssl_socket.hpp d65638b1dc1330c6393dc79efc7226dc9560c3b0
Diff: https://reviews.apache.org/r/35841/diff/
Testing
-------
sudo make check
Thanks,
Paul Brett
Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/
-----------------------------------------------------------
(Updated June 25, 2015, 4:13 a.m.)
Review request for mesos, Benjamin Hindman, Bernd Mathiske, Chi Zhang, Ian Downes, Jie Yu, Joris Van Remoortere, Vinod Kone, and Cong Wang.
Changes
-------
Switch to using default constructors.
Bugs: MESOS-2925
https://issues.apache.org/jira/browse/MESOS-2925
Repository: mesos
Description
-------
Fix usage of ATOMIC_FLAG_INIT
Diffs (updated)
-----
3rdparty/libprocess/include/process/future.hpp b20eb0683c6c4491eabaada46ae8d35d8a89ebaf
3rdparty/libprocess/include/process/http.hpp e47cc7afbc8110759edf25a2dc05d09eda25c417
3rdparty/libprocess/include/process/metrics/metric.hpp 44a7d5a272f5e5e86634c12b1003049ba0e4f932
3rdparty/libprocess/include/process/metrics/timer.hpp fd7b2db15f596b192f64658fae846b3899e8d1d0
3rdparty/libprocess/include/process/mutex.hpp 8fff089e2654bf1a5ac3cfec91def7688e0009ca
3rdparty/libprocess/include/process/queue.hpp 1496b3850648957ff34bf2bbe240d1ab0888c6f8
3rdparty/libprocess/src/libevent_ssl_socket.hpp d65638b1dc1330c6393dc79efc7226dc9560c3b0
Diff: https://reviews.apache.org/r/35841/diff/
Testing
-------
sudo make check
Thanks,
Paul Brett
Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/
-----------------------------------------------------------
(Updated June 25, 2015, 4:02 a.m.)
Review request for mesos, Benjamin Hindman, Bernd Mathiske, Chi Zhang, Ian Downes, Jie Yu, Joris Van Remoortere, Vinod Kone, and Cong Wang.
Changes
-------
Killed a blank line introduced in error.
Bugs: MESOS-2925
https://issues.apache.org/jira/browse/MESOS-2925
Repository: mesos
Description
-------
Fix usage of ATOMIC_FLAG_INIT
Diffs (updated)
-----
3rdparty/libprocess/include/process/future.hpp b20eb0683c6c4491eabaada46ae8d35d8a89ebaf
3rdparty/libprocess/include/process/http.hpp e47cc7afbc8110759edf25a2dc05d09eda25c417
3rdparty/libprocess/include/process/metrics/metric.hpp 44a7d5a272f5e5e86634c12b1003049ba0e4f932
3rdparty/libprocess/include/process/metrics/timer.hpp fd7b2db15f596b192f64658fae846b3899e8d1d0
3rdparty/libprocess/include/process/mutex.hpp 8fff089e2654bf1a5ac3cfec91def7688e0009ca
3rdparty/libprocess/include/process/queue.hpp 1496b3850648957ff34bf2bbe240d1ab0888c6f8
3rdparty/libprocess/src/libevent_ssl_socket.hpp d65638b1dc1330c6393dc79efc7226dc9560c3b0
Diff: https://reviews.apache.org/r/35841/diff/
Testing
-------
sudo make check
Thanks,
Paul Brett
Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/
-----------------------------------------------------------
(Updated June 25, 2015, 3:55 a.m.)
Review request for mesos, Benjamin Hindman, Bernd Mathiske, Chi Zhang, Ian Downes, Jie Yu, Joris Van Remoortere, Vinod Kone, and Cong Wang.
Changes
-------
Switched to inline initializer.
Bugs: MESOS-2925
https://issues.apache.org/jira/browse/MESOS-2925
Repository: mesos
Description
-------
Fix usage of ATOMIC_FLAG_INIT
Diffs (updated)
-----
3rdparty/libprocess/include/process/future.hpp b20eb0683c6c4491eabaada46ae8d35d8a89ebaf
3rdparty/libprocess/include/process/http.hpp e47cc7afbc8110759edf25a2dc05d09eda25c417
3rdparty/libprocess/include/process/metrics/metric.hpp 44a7d5a272f5e5e86634c12b1003049ba0e4f932
3rdparty/libprocess/include/process/metrics/timer.hpp fd7b2db15f596b192f64658fae846b3899e8d1d0
3rdparty/libprocess/include/process/mutex.hpp 8fff089e2654bf1a5ac3cfec91def7688e0009ca
3rdparty/libprocess/include/process/queue.hpp 1496b3850648957ff34bf2bbe240d1ab0888c6f8
3rdparty/libprocess/src/libevent_ssl_socket.hpp d65638b1dc1330c6393dc79efc7226dc9560c3b0
Diff: https://reviews.apache.org/r/35841/diff/
Testing
-------
sudo make check
Thanks,
Paul Brett
Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/#review89275
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35841]
All tests passed.
- Mesos ReviewBot
On June 24, 2015, 8:54 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35841/
> -----------------------------------------------------------
>
> (Updated June 24, 2015, 8:54 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Chi Zhang, Ian Downes, Jie Yu, Joris Van Remoortere, Vinod Kone, and Cong Wang.
>
>
> Bugs: MESOS-2925
> https://issues.apache.org/jira/browse/MESOS-2925
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix usage of ATOMIC_FLAG_INIT
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/future.hpp b20eb0683c6c4491eabaada46ae8d35d8a89ebaf
> 3rdparty/libprocess/include/process/http.hpp e47cc7afbc8110759edf25a2dc05d09eda25c417
> 3rdparty/libprocess/include/process/metrics/metric.hpp 44a7d5a272f5e5e86634c12b1003049ba0e4f932
> 3rdparty/libprocess/include/process/metrics/timer.hpp fd7b2db15f596b192f64658fae846b3899e8d1d0
> 3rdparty/libprocess/include/process/mutex.hpp 8fff089e2654bf1a5ac3cfec91def7688e0009ca
> 3rdparty/libprocess/include/process/queue.hpp 1496b3850648957ff34bf2bbe240d1ab0888c6f8
>
> Diff: https://reviews.apache.org/r/35841/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/
-----------------------------------------------------------
(Updated June 24, 2015, 8:54 p.m.)
Review request for mesos, Benjamin Hindman, Bernd Mathiske, Chi Zhang, Ian Downes, Jie Yu, Joris Van Remoortere, Vinod Kone, and Cong Wang.
Changes
-------
Incorporate reviewer comment.
Bugs: MESOS-2925
https://issues.apache.org/jira/browse/MESOS-2925
Repository: mesos
Description
-------
Fix usage of ATOMIC_FLAG_INIT
Diffs (updated)
-----
3rdparty/libprocess/include/process/future.hpp b20eb0683c6c4491eabaada46ae8d35d8a89ebaf
3rdparty/libprocess/include/process/http.hpp e47cc7afbc8110759edf25a2dc05d09eda25c417
3rdparty/libprocess/include/process/metrics/metric.hpp 44a7d5a272f5e5e86634c12b1003049ba0e4f932
3rdparty/libprocess/include/process/metrics/timer.hpp fd7b2db15f596b192f64658fae846b3899e8d1d0
3rdparty/libprocess/include/process/mutex.hpp 8fff089e2654bf1a5ac3cfec91def7688e0009ca
3rdparty/libprocess/include/process/queue.hpp 1496b3850648957ff34bf2bbe240d1ab0888c6f8
Diff: https://reviews.apache.org/r/35841/diff/
Testing
-------
sudo make check
Thanks,
Paul Brett
Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/#review89246
-----------------------------------------------------------
Ship it!
Great catch! Thanks for these Paul, just minor comments regarding comments :P
3rdparty/libprocess/include/process/future.hpp (lines 816 - 818)
<https://reviews.apache.org/r/35841/#comment141830>
Can we add the comment here as well?
```
// ATOMIC_FLAG_INIT is not available on member locks, so we
// unconditionally clear the lock instead.
```
3rdparty/libprocess/include/process/mutex.hpp (lines 65 - 66)
<https://reviews.apache.org/r/35841/#comment141829>
Can we consistently use this comment? or is this case different somehow?
```
// ATOMIC_FLAG_INIT is not available on member locks, so we
// unconditionally clear the lock instead.
```
- Michael Park
On June 24, 2015, 8:15 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35841/
> -----------------------------------------------------------
>
> (Updated June 24, 2015, 8:15 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Chi Zhang, Ian Downes, Jie Yu, Joris Van Remoortere, Vinod Kone, and Cong Wang.
>
>
> Bugs: MESOS-2925
> https://issues.apache.org/jira/browse/MESOS-2925
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix usage of ATOMIC_FLAG_INIT
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/future.hpp b20eb0683c6c4491eabaada46ae8d35d8a89ebaf
> 3rdparty/libprocess/include/process/http.hpp e47cc7afbc8110759edf25a2dc05d09eda25c417
> 3rdparty/libprocess/include/process/metrics/metric.hpp 44a7d5a272f5e5e86634c12b1003049ba0e4f932
> 3rdparty/libprocess/include/process/metrics/timer.hpp fd7b2db15f596b192f64658fae846b3899e8d1d0
> 3rdparty/libprocess/include/process/mutex.hpp 8fff089e2654bf1a5ac3cfec91def7688e0009ca
> 3rdparty/libprocess/include/process/queue.hpp 1496b3850648957ff34bf2bbe240d1ab0888c6f8
>
> Diff: https://reviews.apache.org/r/35841/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Paul Brett
>
>