[jira] [Resolved] (SIS-71) Consider replacing PT_FreeText by direct annotation of AbstractInternationalString

["Martin Desruisseaux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SIS-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Desruisseaux resolved SIS-71.
------------------------------------

    Resolution: Won't Fix

This task is more complicated than initially though because:

* We have many {{InternationalString}} implementations: {{SimpleInternationalString}}, {{DefaultInternationalString}}, {{ResourceInternationalString}}, plus many inner private classes in resource bundles or {{GenericName}} implementations.
* Choosing a particular {{InternationalString}} implementation to annotate may allow us to replace our {{GCO_CharacterString}} internal wrapper, but the later also handles anchors (which are not {{InternationalString}}'s job) and is used as the base class of countries and language codes.
* If we were choosing a particular implementation to annotate, we would need to choose the most complete one. But in practice, the majority of international strings are instances of {{SimpleInternationalString}}, which would need to be wrapped anyway. Consequently the potential gain of this task is likely to be small.

Applying the "_if it is not broken, don't fix it_" principle, I close this issue as "will not fix".
                
> Consider replacing PT_FreeText by direct annotation of AbstractInternationalString
> ----------------------------------------------------------------------------------
>
>                 Key: SIS-71
>                 URL: https://issues.apache.org/jira/browse/SIS-71
>             Project: Spatial Information Systems
>          Issue Type: Improvement
>          Components: Utilities
>            Reporter: Martin Desruisseaux
>            Assignee: Martin Desruisseaux
>            Priority: Minor
>
> {{PT_FreeText}} is a XML structure formatted like below:
> {code:xml}
> <gmd:title xsi:type="gmd:PT_FreeText_PropertyType">
>   <gco:CharacterString>Some title in english is present in this node</gco:CharacterString>
>   <gmd:PT_FreeText>
>     <gmd:textGroup>
>       <gmd:LocalisedCharacterString locale="#locale-fra">Un titre en français</gmd:LocalisedCharacterString>
>     </gmd:textGroup>
>   </gmd:PT_FreeText>
> </gmd:title>
> {code}
> Currently, this is formatted by an internal {{PT_FreeText}} class used as a wrapper around {{InternationalString}}. We should see if we can annotate {{AbstractInternationalString}} directly instead. This would both simplify a little bit the internal mechanism and create a little bit less objects at marshalling/unmarshalling time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira