You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Nixon Rodrigues <ni...@freestoneinfotech.com> on 2016/12/14 13:12:48 UTC
Review Request 54741: ATLAS-1377 Escaping comma in for LDAP properties
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54741/
-----------------------------------------------------------
Review request for atlas, keval bhatt, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1377
https://issues.apache.org/jira/browse/ATLAS-1377
Repository: atlas
Description
-------
This patch contains fix for ATLAS-1377 :- Escaping comma in for LDAP properties.
Diffs
-----
distro/src/conf/atlas-application.properties eea46a6
webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java aea939a
webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java 468daf6
Diff: https://reviews.apache.org/r/54741/diff/
Testing
-------
Tested both AD and LDAP logins with following atlas configaration.
######## LDAP properties #########
atlas.authentication.method.ldap.type=LDAP
atlas.authentication.method.ldap.url=ldap://XXX.XX.XX.XX:33389
atlas.authentication.method.ldap.userDNpattern=uid={0},ou=people,dc=hadoop,dc=apache,dc=org
atlas.authentication.method.ldap.groupSearchBase=dc=hadoop,dc=apache,dc=org
atlas.authentication.method.ldap.groupSearchFilter=(member=uid={0},ou=people,dc=hadoop,dc=apache,dc=org)
atlas.authentication.method.ldap.groupRoleAttribute=cn
atlas.authentication.method.ldap.base.dn=dc=hadoop,dc=apache,dc=org
atlas.authentication.method.ldap.bind.dn=uid=admin,ou=people,dc=hadoop,dc=apache,dc=org
atlas.authentication.method.ldap.bind.password=p@$$$$wOrd
atlas.authentication.method.ldap.referral=ignore
atlas.authentication.method.ldap.user.searchfilter=(uid={0})
atlas.authentication.method.ldap.default.role=<default role>
######### Active directory properties #######
atlas.authentication.method.ldap.type=AD
atlas.authentication.method.ldap.ad.domain=example.com
atlas.authentication.method.ldap.ad.url=ldap://XXX.XX.XX.XX:389
atlas.authentication.method.ldap.ad.base.dn=(sAMAccountName={0})
atlas.authentication.method.ldap.ad.bind.dn=cn=admin,dc=example,dc=com
atlas.authentication.method.ldap.ad.bind.password=p@$$$$wOrd
atlas.authentication.method.ldap.ad.referral=ignore
atlas.authentication.method.ldap.ad.user.searchfilter=(sAMAccountName={0})
atlas.authentication.method.ldap.ad.default.role=ROLE_USER
Thanks,
Nixon Rodrigues
Re: Review Request 54741: ATLAS-1377 Escaping comma in LDAP properties
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
> On Dec. 14, 2016, 7:15 p.m., Madhan Neethiraj wrote:
> > Changes look good. Can you please verify that this change doesn't break existing configurations that have escaped commas in LDAP properties?
Madhan,
Tested with existing configurations with slash () character for escaping , it works fine.
- Nixon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54741/#review159214
-----------------------------------------------------------
On Dec. 14, 2016, 1:13 p.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54741/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 1:13 p.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1377
> https://issues.apache.org/jira/browse/ATLAS-1377
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch contains fix for ATLAS-1377 :- Escaping comma in for LDAP properties.
>
>
> Diffs
> -----
>
> distro/src/conf/atlas-application.properties eea46a6
> webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java aea939a
> webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java 468daf6
>
> Diff: https://reviews.apache.org/r/54741/diff/
>
>
> Testing
> -------
>
> Tested both AD and LDAP logins with following atlas configaration.
>
> ######## LDAP properties #########
> atlas.authentication.method.ldap.type=LDAP
> atlas.authentication.method.ldap.url=ldap://XXX.XX.XX.XX:33389
> atlas.authentication.method.ldap.userDNpattern=uid={0},ou=people,dc=hadoop,dc=apache,dc=org
> atlas.authentication.method.ldap.groupSearchBase=dc=hadoop,dc=apache,dc=org
> atlas.authentication.method.ldap.groupSearchFilter=(member=uid={0},ou=people,dc=hadoop,dc=apache,dc=org)
> atlas.authentication.method.ldap.groupRoleAttribute=cn
> atlas.authentication.method.ldap.base.dn=dc=hadoop,dc=apache,dc=org
> atlas.authentication.method.ldap.bind.dn=uid=admin,ou=people,dc=hadoop,dc=apache,dc=org
> atlas.authentication.method.ldap.bind.password=p@$$$$wOrd
> atlas.authentication.method.ldap.referral=ignore
> atlas.authentication.method.ldap.user.searchfilter=(uid={0})
> atlas.authentication.method.ldap.default.role=<default role>
>
>
> ######### Active directory properties #######
> atlas.authentication.method.ldap.type=AD
> atlas.authentication.method.ldap.ad.domain=example.com
> atlas.authentication.method.ldap.ad.url=ldap://XXX.XX.XX.XX:389
> atlas.authentication.method.ldap.ad.base.dn=(sAMAccountName={0})
> atlas.authentication.method.ldap.ad.bind.dn=cn=admin,dc=example,dc=com
> atlas.authentication.method.ldap.ad.bind.password=p@$$$$wOrd
> atlas.authentication.method.ldap.ad.referral=ignore
> atlas.authentication.method.ldap.ad.user.searchfilter=(sAMAccountName={0})
> atlas.authentication.method.ldap.ad.default.role=ROLE_USER
>
>
> Thanks,
>
> Nixon Rodrigues
>
>
Re: Review Request 54741: ATLAS-1377 Escaping comma in LDAP properties
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54741/#review159214
-----------------------------------------------------------
Changes look good. Can you please verify that this change doesn't break existing configurations that have escaped commas in LDAP properties?
- Madhan Neethiraj
On Dec. 14, 2016, 1:13 p.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54741/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 1:13 p.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1377
> https://issues.apache.org/jira/browse/ATLAS-1377
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch contains fix for ATLAS-1377 :- Escaping comma in for LDAP properties.
>
>
> Diffs
> -----
>
> distro/src/conf/atlas-application.properties eea46a6
> webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java aea939a
> webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java 468daf6
>
> Diff: https://reviews.apache.org/r/54741/diff/
>
>
> Testing
> -------
>
> Tested both AD and LDAP logins with following atlas configaration.
>
> ######## LDAP properties #########
> atlas.authentication.method.ldap.type=LDAP
> atlas.authentication.method.ldap.url=ldap://XXX.XX.XX.XX:33389
> atlas.authentication.method.ldap.userDNpattern=uid={0},ou=people,dc=hadoop,dc=apache,dc=org
> atlas.authentication.method.ldap.groupSearchBase=dc=hadoop,dc=apache,dc=org
> atlas.authentication.method.ldap.groupSearchFilter=(member=uid={0},ou=people,dc=hadoop,dc=apache,dc=org)
> atlas.authentication.method.ldap.groupRoleAttribute=cn
> atlas.authentication.method.ldap.base.dn=dc=hadoop,dc=apache,dc=org
> atlas.authentication.method.ldap.bind.dn=uid=admin,ou=people,dc=hadoop,dc=apache,dc=org
> atlas.authentication.method.ldap.bind.password=p@$$$$wOrd
> atlas.authentication.method.ldap.referral=ignore
> atlas.authentication.method.ldap.user.searchfilter=(uid={0})
> atlas.authentication.method.ldap.default.role=<default role>
>
>
> ######### Active directory properties #######
> atlas.authentication.method.ldap.type=AD
> atlas.authentication.method.ldap.ad.domain=example.com
> atlas.authentication.method.ldap.ad.url=ldap://XXX.XX.XX.XX:389
> atlas.authentication.method.ldap.ad.base.dn=(sAMAccountName={0})
> atlas.authentication.method.ldap.ad.bind.dn=cn=admin,dc=example,dc=com
> atlas.authentication.method.ldap.ad.bind.password=p@$$$$wOrd
> atlas.authentication.method.ldap.ad.referral=ignore
> atlas.authentication.method.ldap.ad.user.searchfilter=(sAMAccountName={0})
> atlas.authentication.method.ldap.ad.default.role=ROLE_USER
>
>
> Thanks,
>
> Nixon Rodrigues
>
>
Re: Review Request 54741: ATLAS-1377 Escaping comma in LDAP properties
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54741/#review159615
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Dec. 14, 2016, 1:13 p.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54741/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 1:13 p.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1377
> https://issues.apache.org/jira/browse/ATLAS-1377
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch contains fix for ATLAS-1377 :- Escaping comma in for LDAP properties.
>
>
> Diffs
> -----
>
> distro/src/conf/atlas-application.properties eea46a6
> webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java aea939a
> webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java 468daf6
>
> Diff: https://reviews.apache.org/r/54741/diff/
>
>
> Testing
> -------
>
> Tested both AD and LDAP logins with following atlas configaration.
>
> ######## LDAP properties #########
> atlas.authentication.method.ldap.type=LDAP
> atlas.authentication.method.ldap.url=ldap://XXX.XX.XX.XX:33389
> atlas.authentication.method.ldap.userDNpattern=uid={0},ou=people,dc=hadoop,dc=apache,dc=org
> atlas.authentication.method.ldap.groupSearchBase=dc=hadoop,dc=apache,dc=org
> atlas.authentication.method.ldap.groupSearchFilter=(member=uid={0},ou=people,dc=hadoop,dc=apache,dc=org)
> atlas.authentication.method.ldap.groupRoleAttribute=cn
> atlas.authentication.method.ldap.base.dn=dc=hadoop,dc=apache,dc=org
> atlas.authentication.method.ldap.bind.dn=uid=admin,ou=people,dc=hadoop,dc=apache,dc=org
> atlas.authentication.method.ldap.bind.password=p@$$$$wOrd
> atlas.authentication.method.ldap.referral=ignore
> atlas.authentication.method.ldap.user.searchfilter=(uid={0})
> atlas.authentication.method.ldap.default.role=<default role>
>
>
> ######### Active directory properties #######
> atlas.authentication.method.ldap.type=AD
> atlas.authentication.method.ldap.ad.domain=example.com
> atlas.authentication.method.ldap.ad.url=ldap://XXX.XX.XX.XX:389
> atlas.authentication.method.ldap.ad.base.dn=(sAMAccountName={0})
> atlas.authentication.method.ldap.ad.bind.dn=cn=admin,dc=example,dc=com
> atlas.authentication.method.ldap.ad.bind.password=p@$$$$wOrd
> atlas.authentication.method.ldap.ad.referral=ignore
> atlas.authentication.method.ldap.ad.user.searchfilter=(sAMAccountName={0})
> atlas.authentication.method.ldap.ad.default.role=ROLE_USER
>
>
> Thanks,
>
> Nixon Rodrigues
>
>
Re: Review Request 54741: ATLAS-1377 Escaping comma in LDAP properties
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54741/
-----------------------------------------------------------
(Updated Dec. 14, 2016, 1:13 p.m.)
Review request for atlas, keval bhatt, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Summary (updated)
-----------------
ATLAS-1377 Escaping comma in LDAP properties
Bugs: ATLAS-1377
https://issues.apache.org/jira/browse/ATLAS-1377
Repository: atlas
Description
-------
This patch contains fix for ATLAS-1377 :- Escaping comma in for LDAP properties.
Diffs
-----
distro/src/conf/atlas-application.properties eea46a6
webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java aea939a
webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java 468daf6
Diff: https://reviews.apache.org/r/54741/diff/
Testing
-------
Tested both AD and LDAP logins with following atlas configaration.
######## LDAP properties #########
atlas.authentication.method.ldap.type=LDAP
atlas.authentication.method.ldap.url=ldap://XXX.XX.XX.XX:33389
atlas.authentication.method.ldap.userDNpattern=uid={0},ou=people,dc=hadoop,dc=apache,dc=org
atlas.authentication.method.ldap.groupSearchBase=dc=hadoop,dc=apache,dc=org
atlas.authentication.method.ldap.groupSearchFilter=(member=uid={0},ou=people,dc=hadoop,dc=apache,dc=org)
atlas.authentication.method.ldap.groupRoleAttribute=cn
atlas.authentication.method.ldap.base.dn=dc=hadoop,dc=apache,dc=org
atlas.authentication.method.ldap.bind.dn=uid=admin,ou=people,dc=hadoop,dc=apache,dc=org
atlas.authentication.method.ldap.bind.password=p@$$$$wOrd
atlas.authentication.method.ldap.referral=ignore
atlas.authentication.method.ldap.user.searchfilter=(uid={0})
atlas.authentication.method.ldap.default.role=<default role>
######### Active directory properties #######
atlas.authentication.method.ldap.type=AD
atlas.authentication.method.ldap.ad.domain=example.com
atlas.authentication.method.ldap.ad.url=ldap://XXX.XX.XX.XX:389
atlas.authentication.method.ldap.ad.base.dn=(sAMAccountName={0})
atlas.authentication.method.ldap.ad.bind.dn=cn=admin,dc=example,dc=com
atlas.authentication.method.ldap.ad.bind.password=p@$$$$wOrd
atlas.authentication.method.ldap.ad.referral=ignore
atlas.authentication.method.ldap.ad.user.searchfilter=(sAMAccountName={0})
atlas.authentication.method.ldap.ad.default.role=ROLE_USER
Thanks,
Nixon Rodrigues