You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/07/23 20:18:12 UTC
Review Request 71146: Clarified a comment in storage local resource
provider tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71146/
-----------------------------------------------------------
Review request for mesos and Chun-Hung Hsiao.
Bugs: MESOS-9254
https://issues.apache.org/jira/browse/MESOS-9254
Repository: mesos
Description
-------
Clarified a comment in storage local resource provider tests.
Diffs
-----
src/tests/storage_local_resource_provider_tests.cpp 69861265d94ddf344da96b593797ce145394413e
Diff: https://reviews.apache.org/r/71146/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 71146: Clarified a comment in storage local
resource provider tests.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71146/
-----------------------------------------------------------
(Updated July 29, 2019, 10:56 a.m.)
Review request for mesos and Chun-Hung Hsiao.
Changes
-------
Address Chun's comment on comment
Bugs: MESOS-9254
https://issues.apache.org/jira/browse/MESOS-9254
Repository: mesos
Description
-------
Clarified a comment in storage local resource provider tests.
Diffs (updated)
-----
src/tests/storage_local_resource_provider_tests.cpp 69b59d48ceefebbb7accefe411c54ac5cecff1c3
Diff: https://reviews.apache.org/r/71146/diff/2/
Changes: https://reviews.apache.org/r/71146/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 71146: Clarified a comment in storage local
resource provider tests.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71146/#review216875
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/storage_local_resource_provider_tests.cpp
Line 615 (original), 615 (patched)
<https://reviews.apache.org/r/71146/#comment304119>
The RP "daemon" does not "get subscribed." The RP daemon is started after agent registration, which instantiate the resource providers, which subscribes to the RP manager.
So maybe "Since the local resource provider gets subscribed after the agent is registered?"
Ditto below.
- Chun-Hung Hsiao
On July 23, 2019, 8:18 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71146/
> -----------------------------------------------------------
>
> (Updated July 23, 2019, 8:18 p.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-9254
> https://issues.apache.org/jira/browse/MESOS-9254
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Clarified a comment in storage local resource provider tests.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp 69861265d94ddf344da96b593797ce145394413e
>
>
> Diff: https://reviews.apache.org/r/71146/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>