You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/07/19 17:25:04 UTC

[GitHub] zone1511 opened a new issue #1475: checkstyle codestyle inconsistent

zone1511 opened a new issue #1475: checkstyle codestyle inconsistent
URL: https://github.com/apache/incubator-skywalking/issues/1475
 
 
   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [x] Feature or performance improvement
   
   ___
   ### Requirement or improvement
   - Right now checkstyle didnt enforce all codestyle required stored in codestyle.xml, for example, Annotation should be wrapped as mention in codestyle.xml `<option name="METHOD_ANNOTATION_WRAP" value="1"/>` However, there are many code violated this requirement. For example in code `org.apache.skywalking.apm.plugin.jdbc.mysql.define.CallableInstrumentation` 
   ```java
    @Override protected ConstructorInterceptPoint[] getConstructorsInterceptPoints() {
   ```
   the Annotation is in the same line as the method which violated the `METHOD_ANNOTATION_WRAP` requirement in codestyle.xml.
   Is there any plan to sync checkstyle and codestyle?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services