[jira] [Commented] (HBASE-5502) region_mover.rb fails to load regions back to original server for regions only containing empty tables.

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220004#comment-13220004 ] 

Hadoop QA commented on HBASE-5502:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12516672/HDFS-5502.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated -131 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 155 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.mapreduce.TestImportTsv
                  org.apache.hadoop.hbase.mapred.TestTableMapReduce
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1066//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1066//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1066//console

This message is automatically generated.
                
> region_mover.rb fails to load regions back to original server for regions only containing empty tables.
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5502
>                 URL: https://issues.apache.org/jira/browse/HBASE-5502
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.92.0
>         Environment: Ubuntu precise
>            Reporter: James Page
>            Priority: Minor
>         Attachments: HDFS-5502.patch
>
>
> The region_mover loadRegion function incorrectly uses 'isSuccessfulScan':
> {noformat} 
>   for r in regions
>     exists = false
>     begin
>       exists = isSuccessfulScan(admin, r)
>     rescue org.apache.hadoop.hbase.NotServingRegionException => e
>       $LOG.info("Failed scan of " + e.message)
>     end
> {noformat} 
> isSuccessfulScan throws an exception when it fails rather than returning status.
> As a result empty regions don't get restored - this is the case in a fresh install (which is how I discovered this) with no user table.
> Modifying the code to set exists IF isSuccessfulScan does not throw an exception worked for me:
> {noformat}
>   for r in regions
>     exists = false
>     begin
>       isSuccessfulScan(admin, r)
>       exists = true
>     rescue org.apache.hadoop.hbase.NotServingRegionException => e
>       $LOG.info("Failed scan of " + e.message)
>     end
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira