You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/01 14:33:39 UTC
[jira] [Commented] (CB-10430) cordova-common events don't reach
platform's code
[ https://issues.apache.org/jira/browse/CB-10430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126239#comment-15126239 ]
ASF GitHub Bot commented on CB-10430:
-------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/370
CB-10430 Allow to modify events source
This fixes [CB-10430](https://issues.apache.org/jira/browse/CB-10430).
This change is needed to allow other tools to replace default `EventEmitter` instance to custom one (e.g. platform might want to replace default `EventEmitter` with the one provided by caller in order to pass these events to upstream code)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-10430
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/370.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #370
----
commit 66ee6a90ad30b708c1ebcf2abf01773d8ab42c6e
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2016-01-12T07:56:59Z
CB-10430 Allow to modify events source
----
> cordova-common events don't reach platform's code
> -------------------------------------------------
>
> Key: CB-10430
> URL: https://issues.apache.org/jira/browse/CB-10430
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaCommon
> Affects Versions: 1.0.0
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
> Labels: common, logging, triaged
> Fix For: 1.1.0
>
>
> I was looking to get verbose output of cordova-windows to see what external commands it is running on my behalf. I was hoping the APIfication with use of superspawn will help here. However, that does not seem to be the case – even though the code seems to suggest that.
> {code}
> exports.spawn = function(cmd, args, opts) {
> ..
> events.emit(opts.printCommand ? 'log' : 'verbose', 'Running command: ' + maybeQuote(cmd) + ' ' + args.map(maybeQuote).join(' '));
> ..
> }
> {code}
> {noformat}
> λ cordova build windows --verbose -- --appx=uap --verbose
> Executing "before_build" hook for all plugins.
> Executing "before_prepare" hook for all plugins.
> Searching PlatformJson files for differences between project vs. platform installed plugins
> No differences found between project and windows platform. Continuing...
> Generating config.xml from defaults for platform "windows"
> Updated project successfully
> Executing "after_prepare" hook for all plugins.
> Executing "before_compile" hook for all plugins.
> Searching for available MSBuild versions...
> Found MSBuild v14.0 at C:\Program Files (x86)\MSBuild\14.0\bin
> Found MSBuild v12.0 at C:\Program Files (x86)\MSBuild\12.0\bin\amd64\
> Found MSBuild v4.0 at C:\Windows\Microsoft.NET\Framework64\v4.0.30319\
> Building project: d:\apps\app\platforms\windows\CordovaApp.Windows10.jsproj
> Configuration : debug
> Platform : anycpu
> C:\Program Files (x86)\MSBuild\Microsoft\NuGet\Microsoft.NuGet.targets(181,5): error : Couldn't find the required information in the lock file. Make sure you have .NETCore,Version=v5.0/win10-anycpu mentioned in your targets. [ d:\apps\app\platforms\windows\CordovaApp.Windows10.jsproj]
> ERROR building one of the platforms: Error: C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe: Command failed with exit code 1
> You may not have the required environment or OS to build this project
> Error: C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe: Command failed with exit code 1
> at ChildProcess.whenDone (d:\apps\app\platforms\windows\cordova\node_modules\cordova-common\src\superspawn.js:139:23)
> at emitTwo (events.js:87:13)
> at ChildProcess.emit (events.js:172:7)
> at maybeClose (internal/child_process.js:817:16)
> at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
> {noformat}
> As you can see there is no “Running command …”
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org