[GitHub] wicket pull request #296: BufferedWebResponse's Cleanup

[Jezza <gi...@git.apache.org>]

GitHub user Jezza opened a pull request:

    https://github.com/apache/wicket/pull/296

    BufferedWebResponse's Cleanup

    As I was debugging an issue I was having, I saw this class being a bit outdated.
    Thought I'd just give it a bit of face lift.
    The main goal was to simplify the 10-15 classes in there that was just used for a single method invocation.
    Ideally, I've pushed all of that functionality into a single class, and the lambda for a given action.
    We still need the class because of the action type, but now there's no need for the 10+ classes.
    
    Open to suggestions for any more improvements.
    For example, I don't know if it was a wise choice to use the ActionType as the constructor for the action.
    It makes it a bit nicer to read over constructing an Action manually.
    
    I was also tempted to run my formatter over it, but I thought against it.
    I actually don't know what template rules wicket follows, if any.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Jezza/wicket buffered

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/wicket/pull/296.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #296
    
----
commit b2f80ab87dc6943c88bed8400d8e623d317374e0
Author: Jezza <je...@...>
Date:   2018-10-15T21:41:30Z

    Cleanup BufferedWebResponse's internals with a more updated idiomatic solution.

----


---

[GitHub] wicket issue #296: Simplify BufferedWebResponse's implementation

[bitstorm <gi...@git.apache.org>]

Github user bitstorm commented on the issue:

    https://github.com/apache/wicket/pull/296
  
    @Jezza Code rules can be found in wicket-core which contains file EclipseCodeFormat.xml. Unfortunately this file is not documented anywhere yet. 


---

[GitHub] wicket issue #296: Simplify BufferedWebResponse's implementation

[Jezza <gi...@git.apache.org>]

Github user Jezza commented on the issue:

    https://github.com/apache/wicket/pull/296
  
    @bitstorm Ah, must have missed it.
    I'll do my best to stick to it.


---