[GitHub] [calcite] shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

[GitBox <gi...@apache.org>]

shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…
URL: https://github.com/apache/calcite/pull/1447#discussion_r322324063
 
 

 ##########
 File path: elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchSchemaFactory.java
 ##########
 @@ -62,8 +62,9 @@ public ElasticsearchSchemaFactory() {
       final Map<String, Integer> coordinates = mapper.readValue(coordinatesString,
           new TypeReference<Map<String, Integer>>() { });
 
+      final String scheme = (String) map.get("scheme");
 
 Review comment:
   Scheme can't be supplied in coordinates like:
    "coordinates": "{'https://vpc.xxx': 443}" otherwise it fails in later steps of ElasticsearchTransport. So the scheme has to be separately supplied.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services