You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Jason Gustafson (JIRA)" <ji...@apache.org> on 2016/09/15 01:06:20 UTC

[jira] [Resolved] (KAFKA-4172) Fix masked test error in KafkaConsumerTest.testSubscriptionChangesWithAutoCommitEnabled

     [ https://issues.apache.org/jira/browse/KAFKA-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Gustafson resolved KAFKA-4172.
------------------------------------
    Resolution: Fixed

Issue resolved by pull request 1857
[https://github.com/apache/kafka/pull/1857]

> Fix masked test error in KafkaConsumerTest.testSubscriptionChangesWithAutoCommitEnabled
> ---------------------------------------------------------------------------------------
>
>                 Key: KAFKA-4172
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4172
>             Project: Kafka
>          Issue Type: Bug
>          Components: consumer, unit tests
>            Reporter: Jason Gustafson
>            Assignee: Jason Gustafson
>             Fix For: 0.10.1.0
>
>
> This test case has an incorrectly matched mock fetch response, which was silently raising an NPE, which was caught in NetworkClient. In general, aside from fixing the test, we are probably missing a null check in the FetchRespose to verify that the partitions included in the fetch response were actually requested. This is usually not a problem because the broker doesn't send us invalid fetch responses, but it's probably better to be a little more defensive when handling responses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)