You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by r-kamath <gi...@git.apache.org> on 2016/03/09 13:08:22 UTC

[GitHub] incubator-zeppelin pull request: Fix Selenium test url

GitHub user r-kamath opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/771

    Fix Selenium test url

    ### What is this PR for?
    use env variable `url` instead of system property
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    * ZEPPELIN-729
    
    ### How should this be tested?
    Change the domain name or port and set a new env variable called `url` with the new url


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/r-kamath/incubator-zeppelin fixSeleniumTestUrl

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/771.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #771
    
----
commit de76168e7da497e321599c8fc997f212c5f84c6b
Author: Renjith Kamath <re...@gmail.com>
Date:   2016-03-09T12:00:13Z

    Fix Selenium test url
    
    - use env variable url instead of system property

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix Selenium test url

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/771#issuecomment-194347021
  
    Good find, LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix Selenium test url

Posted by felixcheung <gi...@git.apache.org>.

Github user felixcheung commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/771#issuecomment-195606226
  
    LGTM
    merging if no more comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix Selenium test url

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/771


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---