[GitHub] [iceberg] dimas-b commented on a diff in pull request #6656: Nessie: Avoid usage of deprecated APIs in test

["dimas-b (via GitHub)" <gi...@apache.org>]

dimas-b commented on code in PR #6656:
URL: https://github.com/apache/iceberg/pull/6656#discussion_r1085396302


##########
nessie/src/test/java/org/apache/iceberg/nessie/BaseTestIceberg.java:
##########
@@ -114,8 +113,8 @@ private void resetData() throws NessieConflictException, NessieNotFoundException
   }
 
   @BeforeEach
-  public void beforeEach(@NessieUri URI nessieUri) throws IOException {
-    this.uri = nessieUri.toString();
+  public void beforeEach(@NessieClientUri URI nessieUri) throws IOException {
+    this.uri = nessieUri.resolve("v1").toASCIIString();

Review Comment:
   With `@NessieClientUri` it is preferable to also use `@NessieApiVersions` (cf. examples in the Nessie repo). This way, the test framework will inject the correct URI for the API version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org