[GitHub] [fineract] adamsaghy commented on a diff in pull request #3170: [FINERACT-1906] Add disbursement charge to accrual transactions

["adamsaghy (via GitHub)" <gi...@apache.org>]

adamsaghy commented on code in PR #3170:
URL: https://github.com/apache/fineract/pull/3170#discussion_r1196573857


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -484,6 +486,15 @@ public CommandProcessingResult disburseLoan(final Long loanId, final JsonCommand
                     && loanCharge.isChargePending()) {
                 disBuLoanCharges.put(loanCharge.getId(), loanCharge.amountOutstanding());
             }
+            if (loanCharge.isDisbursementCharge()) {

Review Comment:
   @taskain7 Agree on this. Why do it need to be native query?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org