You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@linkis.apache.org by GitBox <gi...@apache.org> on 2022/02/08 08:13:27 UTC

[GitHub] [incubator-linkis] peacewong commented on a change in pull request #1377: involve skywalking agent for linkis services

peacewong commented on a change in pull request #1377:
URL: https://github.com/apache/incubator-linkis/pull/1377#discussion_r801361024



##########
File path: assembly-combined-package/deploy-config/linkis-env.sh
##########
@@ -139,3 +139,6 @@ LINKIS_VERSION=1.0.3
 
 # for install
 LINKIS_PUBLIC_MODULE=lib/linkis-commons/public-module
+
+## If SKYWALKING_AGENT_PATH is set, the Linkis components will be started with Skywalking agent
+SKYWALKING_AGENT_PATH=/appcom/config/skywalking-agent/skywalking-agent.jar

Review comment:
       Is it better to comment it out by default? It only opens if you need to open SkyWalking




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org