You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/25 02:16:03 UTC

[GitHub] [flink] JingsongLi opened a new pull request #12309: [FLINK-17889][hive] Hive jar should not include format java service file

JingsongLi opened a new pull request #12309:
URL: https://github.com/apache/flink/pull/12309


   
   ## What is the purpose of the change
   
   Hive jar should not include format java SPI file.
   
   ## Brief change log
   
   - Modify hive pom to exclude SPI file.
   - relocation flink-parquet
   
   ## Verifying this change
   
   Manually testing.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] JingsongLi merged pull request #12309: [FLINK-17889][hive] Hive can not work with filesystem connector

Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #12309:
URL: https://github.com/apache/flink/pull/12309


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12309: [FLINK-17889][hive] Hive can not work with filesystem connector

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12309:
URL: https://github.com/apache/flink/pull/12309#issuecomment-633343729


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit f6aec0584d0e5ba97e7b5c4707d93d97465b4704 (Fri Oct 16 10:54:57 UTC 2020)
   
   **Warnings:**
    * **1 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12309: [FLINK-17889][hive] Hive jar should not include format java service file

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12309:
URL: https://github.com/apache/flink/pull/12309#issuecomment-633343729


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit c0f98fc48c889443462b8a1056e50ce8082d0314 (Mon May 25 02:18:40 UTC 2020)
   
   **Warnings:**
    * **1 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12309: [FLINK-17889][hive] Hive can not work with filesystem connector

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12309:
URL: https://github.com/apache/flink/pull/12309#issuecomment-633345845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c0f98fc48c889443462b8a1056e50ce8082d0314",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2095",
       "triggerID" : "c0f98fc48c889443462b8a1056e50ce8082d0314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f6aec0584d0e5ba97e7b5c4707d93d97465b4704",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2112",
       "triggerID" : "f6aec0584d0e5ba97e7b5c4707d93d97465b4704",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c0f98fc48c889443462b8a1056e50ce8082d0314 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2095) 
   * f6aec0584d0e5ba97e7b5c4707d93d97465b4704 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2112) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12309: [FLINK-17889][hive] Hive can not work with filesystem connector

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12309:
URL: https://github.com/apache/flink/pull/12309#issuecomment-633345845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c0f98fc48c889443462b8a1056e50ce8082d0314",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2095",
       "triggerID" : "c0f98fc48c889443462b8a1056e50ce8082d0314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f6aec0584d0e5ba97e7b5c4707d93d97465b4704",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f6aec0584d0e5ba97e7b5c4707d93d97465b4704",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c0f98fc48c889443462b8a1056e50ce8082d0314 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2095) 
   * f6aec0584d0e5ba97e7b5c4707d93d97465b4704 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] lirui-apache commented on pull request #12309: [FLINK-17889][hive] Hive can not work with filesystem connector

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on pull request #12309:
URL: https://github.com/apache/flink/pull/12309#issuecomment-633358202


   One minor suggestion: we should use the same package prefix for all the shaded dependencies.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12309: [FLINK-17889][hive] Hive can not work with filesystem connector

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12309:
URL: https://github.com/apache/flink/pull/12309#issuecomment-633345845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c0f98fc48c889443462b8a1056e50ce8082d0314",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2095",
       "triggerID" : "c0f98fc48c889443462b8a1056e50ce8082d0314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f6aec0584d0e5ba97e7b5c4707d93d97465b4704",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2112",
       "triggerID" : "f6aec0584d0e5ba97e7b5c4707d93d97465b4704",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f6aec0584d0e5ba97e7b5c4707d93d97465b4704 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2112) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12309: [FLINK-17889][hive] Hive can not work with filesystem connector

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12309:
URL: https://github.com/apache/flink/pull/12309#issuecomment-633345845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c0f98fc48c889443462b8a1056e50ce8082d0314",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2095",
       "triggerID" : "c0f98fc48c889443462b8a1056e50ce8082d0314",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c0f98fc48c889443462b8a1056e50ce8082d0314 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2095) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12309: [FLINK-17889][hive] Hive can not work with filesystem connector

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12309:
URL: https://github.com/apache/flink/pull/12309#issuecomment-633345845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c0f98fc48c889443462b8a1056e50ce8082d0314",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2095",
       "triggerID" : "c0f98fc48c889443462b8a1056e50ce8082d0314",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c0f98fc48c889443462b8a1056e50ce8082d0314 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2095) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12309: [FLINK-17889][hive] Hive jar should not include format java service file

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12309:
URL: https://github.com/apache/flink/pull/12309#issuecomment-633345845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c0f98fc48c889443462b8a1056e50ce8082d0314",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c0f98fc48c889443462b8a1056e50ce8082d0314",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c0f98fc48c889443462b8a1056e50ce8082d0314 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org