You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2018/12/07 17:11:57 UTC
[kudu-CR](gh-pages) [docs] Update docs with contributing to blog
Hello Mike Percy, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12055
to review the following change.
Change subject: [docs] Update docs with contributing to blog
......................................................................
[docs] Update docs with contributing to blog
This commit replaces the docs symlink (which pointed to
releases/1.8.0/docs) with a new docs directory to be able to publish
this new section (added in 7adcba3) which is not tagged in a release
yet.
Change-Id: Ib96096bae24ae97bd51f39cbf8867e822492ea69
---
D docs
A docs/administration.html
A docs/background_tasks.html
A docs/command_line_tools.html
A docs/command_line_tools_reference.html
A docs/configuration.html
A docs/configuration_reference.html
A docs/configuration_reference_unsupported.html
A docs/contributing.html
A docs/developing.html
A docs/export_control.html
A docs/images/hash-hash-partitioning-example.png
A docs/images/hash-partitioning-example.png
A docs/images/hash-range-partitioning-example.png
A docs/images/kudu-architecture-2.png
A docs/images/range-partitioning-example.png
A docs/index.html
A docs/installation.html
A docs/known_issues.html
A docs/kudu-master_configuration_reference.html
A docs/kudu-master_configuration_reference_unsupported.html
A docs/kudu-tserver_configuration_reference.html
A docs/kudu-tserver_configuration_reference_unsupported.html
A docs/kudu_impala_integration.html
A docs/prior_release_notes.html
A docs/quickstart.html
A docs/release_notes.html
A docs/scaling_guide.html
A docs/schema_design.html
A docs/security.html
A docs/transaction_semantics.html
A docs/troubleshooting.html
32 files changed, 65,813 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/12055/1
--
To view, visit http://gerrit.cloudera.org:8080/12055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib96096bae24ae97bd51f39cbf8867e822492ea69
Gerrit-Change-Number: 12055
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR](gh-pages) [docs] Update docs with contributing to blog
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12055 )
Change subject: [docs] Update docs with contributing to blog
......................................................................
Patch Set 1: Verified+1 Code-Review+2
I suppose we can always change back next release. WFM.
--
To view, visit http://gerrit.cloudera.org:8080/12055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib96096bae24ae97bd51f39cbf8867e822492ea69
Gerrit-Change-Number: 12055
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 11 Dec 2018 19:41:01 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [docs] Update docs with contributing to blog
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12055 )
Change subject: [docs] Update docs with contributing to blog
......................................................................
Patch Set 1:
I wonder if we should still use 1.8.0 symlink? Breaking the pattern doesn't seam great. Are the docs are still relevant for 1.8.0?
--
To view, visit http://gerrit.cloudera.org:8080/12055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib96096bae24ae97bd51f39cbf8867e822492ea69
Gerrit-Change-Number: 12055
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 07 Dec 2018 17:16:07 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [docs] Update docs with contributing to blog
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12055 )
Change subject: [docs] Update docs with contributing to blog
......................................................................
[docs] Update docs with contributing to blog
This commit replaces the docs symlink (which pointed to
releases/1.8.0/docs) with a new docs directory to be able to publish
this new section (added in 7adcba3) which is not tagged in a release
yet.
Change-Id: Ib96096bae24ae97bd51f39cbf8867e822492ea69
Reviewed-on: http://gerrit.cloudera.org:8080/12055
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
D docs
A docs/administration.html
A docs/background_tasks.html
A docs/command_line_tools.html
A docs/command_line_tools_reference.html
A docs/configuration.html
A docs/configuration_reference.html
A docs/configuration_reference_unsupported.html
A docs/contributing.html
A docs/developing.html
A docs/export_control.html
A docs/images/hash-hash-partitioning-example.png
A docs/images/hash-partitioning-example.png
A docs/images/hash-range-partitioning-example.png
A docs/images/kudu-architecture-2.png
A docs/images/range-partitioning-example.png
A docs/index.html
A docs/installation.html
A docs/known_issues.html
A docs/kudu-master_configuration_reference.html
A docs/kudu-master_configuration_reference_unsupported.html
A docs/kudu-tserver_configuration_reference.html
A docs/kudu-tserver_configuration_reference_unsupported.html
A docs/kudu_impala_integration.html
A docs/prior_release_notes.html
A docs/quickstart.html
A docs/release_notes.html
A docs/scaling_guide.html
A docs/schema_design.html
A docs/security.html
A docs/transaction_semantics.html
A docs/troubleshooting.html
32 files changed, 65,813 insertions(+), 1 deletion(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib96096bae24ae97bd51f39cbf8867e822492ea69
Gerrit-Change-Number: 12055
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR](gh-pages) [docs] Update docs with contributing to blog
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12055 )
Change subject: [docs] Update docs with contributing to blog
......................................................................
Patch Set 1:
> Patch Set 1:
>
> I wonder if we should still use 1.8.0 symlink? Breaking the pattern doesn't seam great. Are the docs are still relevant for 1.8.0?
Yeah, the only relevant commit backported to branch-1.8.x is this, it just felt wrong touching anything in releases/1.8.0. This pattern is pretty new too, previously docs was a directory instead of a symlink, 1.8.0 is the first release that I know of that linked it instead.
--
To view, visit http://gerrit.cloudera.org:8080/12055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib96096bae24ae97bd51f39cbf8867e822492ea69
Gerrit-Change-Number: 12055
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 07 Dec 2018 17:41:00 +0000
Gerrit-HasComments: No