You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/12/04 01:45:58 UTC
Review Request 28684: Renamed task and offer visitors to validators.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28684/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
Renamed task and offer visitors to validators.
Diffs
-----
src/master/master.hpp e6ed87da8bbe56ce693547c227149312ba24f457
src/master/master.cpp 3dc4e7a64bb28ab111fe6ed71eb87064f416acfd
Diff: https://reviews.apache.org/r/28684/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 28684: Renamed task and offer visitors to
validators.
Posted by Jie Yu <yu...@gmail.com>.
> On Dec. 4, 2014, 12:54 a.m., Ben Mahler wrote:
> > src/master/master.cpp, lines 1799-1800
> > <https://reviews.apache.org/r/28684/diff/1/?file=782165#file782165line1799>
> >
> > Visitor pattern no longer relevant.
Done.
> On Dec. 4, 2014, 12:54 a.m., Ben Mahler wrote:
> > src/master/master.cpp, lines 1802-1803
> > <https://reviews.apache.org/r/28684/diff/1/?file=782165#file782165line1802>
> >
> > This note about typedef is no longer true.
Done.
> On Dec. 4, 2014, 12:54 a.m., Ben Mahler wrote:
> > src/master/master.cpp, lines 1804-1807
> > <https://reviews.apache.org/r/28684/diff/1/?file=782165#file782165line1804>
> >
> > Let's also do s/task description/task/
Done.
> On Dec. 4, 2014, 12:54 a.m., Ben Mahler wrote:
> > src/master/master.cpp, line 2274
> > <https://reviews.apache.org/r/28684/diff/1/?file=782165#file782165line2274>
> >
> > s/Checks/Validates/ here and in all cases above.
Done.
> On Dec. 4, 2014, 12:54 a.m., Ben Mahler wrote:
> > src/master/master.cpp, line 2337
> > <https://reviews.apache.org/r/28684/diff/1/?file=782165#file782165line2337>
> >
> > Hm.. could we just use std::array? Looks like it is included in 4.4: https://gcc.gnu.org/ml/libstdc++/2010-03/msg00046.html
> >
> > Ditto for task validators.
Since we don't have configure check yet. Punt this for now.
> On Dec. 4, 2014, 12:54 a.m., Ben Mahler wrote:
> > src/master/master.cpp, line 2447
> > <https://reviews.apache.org/r/28684/diff/1/?file=782165#file782165line2447>
> >
> > s/checkers/validators/
Done.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28684/#review63791
-----------------------------------------------------------
On Dec. 4, 2014, 12:45 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28684/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2014, 12:45 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Renamed task and offer visitors to validators.
>
>
> Diffs
> -----
>
> src/master/master.hpp e6ed87da8bbe56ce693547c227149312ba24f457
> src/master/master.cpp 3dc4e7a64bb28ab111fe6ed71eb87064f416acfd
>
> Diff: https://reviews.apache.org/r/28684/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 28684: Renamed task and offer visitors to
validators.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28684/#review63791
-----------------------------------------------------------
Ship it!
Thanks jie! Make sure to update all the comments per my suggestions below.
src/master/master.cpp
<https://reviews.apache.org/r/28684/#comment106093>
Visitor pattern no longer relevant.
src/master/master.cpp
<https://reviews.apache.org/r/28684/#comment106092>
This note about typedef is no longer true.
src/master/master.cpp
<https://reviews.apache.org/r/28684/#comment106097>
Let's also do s/task description/task/
src/master/master.cpp
<https://reviews.apache.org/r/28684/#comment106096>
s/Checks/Validates/ here and in all cases above.
src/master/master.cpp
<https://reviews.apache.org/r/28684/#comment106095>
Hm.. could we just use std::array? Looks like it is included in 4.4: https://gcc.gnu.org/ml/libstdc++/2010-03/msg00046.html
Ditto for task validators.
src/master/master.cpp
<https://reviews.apache.org/r/28684/#comment106094>
s/checkers/validators/
- Ben Mahler
On Dec. 4, 2014, 12:45 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28684/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2014, 12:45 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Renamed task and offer visitors to validators.
>
>
> Diffs
> -----
>
> src/master/master.hpp e6ed87da8bbe56ce693547c227149312ba24f457
> src/master/master.cpp 3dc4e7a64bb28ab111fe6ed71eb87064f416acfd
>
> Diff: https://reviews.apache.org/r/28684/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>