You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by ion2014 <gi...@git.apache.org> on 2018/11/09 07:37:11 UTC
[GitHub] hawq pull request #1400: HAWQ-1674. add cpp compile support for orc_format
GitHub user ion2014 opened a pull request:
https://github.com/apache/hawq/pull/1400
HAWQ-1674. add cpp compile support for orc_format
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ion2014/hawq plug_orc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/hawq/pull/1400.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1400
----
commit 6fb3b7c61c493898f8637b9c165a240c86a28ff6
Author: ion2014 <lo...@...>
Date: 2018-11-08T07:27:36Z
HAWQ-1671. Add compile support for orc formatter and wrapper
Changed Makefile in contrib/orc
Add folder format and cwrapper for split compilation
Add dummy code for testing the Makefile
commit 883f7d387d36ed5c07dae8bf455a4815731aa4ac
Author: ion2014 <lo...@...>
Date: 2018-11-09T07:19:11Z
HAWQ-1674. Add support for compiling CPP projects in orc_format.
add cwrapper.cpp to generate interface code for C/C++ link.
changed Makefile to support cpp compiling.
----
---
[GitHub] hawq pull request #1400: HAWQ-1674. add cpp compile support for orc_format
Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang commented on a diff in the pull request:
https://github.com/apache/hawq/pull/1400#discussion_r232572061
--- Diff: contrib/orc/cwrapper/format/orc_format.cpp ---
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#include "../cwrapper.h"
--- End diff --
better to use a full path instead an absolute path
---
[GitHub] hawq pull request #1400: HAWQ-1674. add cpp compile support for orc_format
Posted by ion2014 <gi...@git.apache.org>.
Github user ion2014 closed the pull request at:
https://github.com/apache/hawq/pull/1400
---
[GitHub] hawq pull request #1400: HAWQ-1674. add cpp compile support for orc_format
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/hawq/pull/1400#discussion_r232167753
--- Diff: contrib/orc/Makefile ---
@@ -16,12 +16,11 @@
# under the License.
#
MODULE_big = orc
-OBJS = cwrapper/cwrapper.o format/orc_format.o orc.o
+OBJS = cwrapper/cwrapper.o orc.o
--- End diff --
The folder can be as below:
```
contrib/orc/orc.c
/cwrapper/cwrapper.cpp .h
/format/format.cc .h
```
---
[GitHub] hawq pull request #1400: HAWQ-1674. add cpp compile support for orc_format
Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang commented on a diff in the pull request:
https://github.com/apache/hawq/pull/1400#discussion_r232571569
--- Diff: contrib/orc/cwrapper/format/Makefile ---
@@ -0,0 +1,6 @@
+All: orc_format.so
--- End diff --
this target should be "all" ? stay consistent with top level target for "all". correct me if this can work too.
---
[GitHub] hawq pull request #1400: HAWQ-1674. add cpp compile support for orc_format
Posted by ion2014 <gi...@git.apache.org>.
GitHub user ion2014 reopened a pull request:
https://github.com/apache/hawq/pull/1400
HAWQ-1674. add cpp compile support for orc_format
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ion2014/hawq plug_orc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/hawq/pull/1400.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1400
----
commit 6fb3b7c61c493898f8637b9c165a240c86a28ff6
Author: ion2014 <lo...@...>
Date: 2018-11-08T07:27:36Z
HAWQ-1671. Add compile support for orc formatter and wrapper
Changed Makefile in contrib/orc
Add folder format and cwrapper for split compilation
Add dummy code for testing the Makefile
commit 883f7d387d36ed5c07dae8bf455a4815731aa4ac
Author: ion2014 <lo...@...>
Date: 2018-11-09T07:19:11Z
HAWQ-1674. Add support for compiling CPP projects in orc_format.
add cwrapper.cpp to generate interface code for C/C++ link.
changed Makefile to support cpp compiling.
----
---
[GitHub] hawq issue #1400: HAWQ-1674. add cpp compile support for orc_format
Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang commented on the issue:
https://github.com/apache/hawq/pull/1400
also, pls make sure the commit can pass all the checks.
---
[GitHub] hawq pull request #1400: HAWQ-1674. add cpp compile support for orc_format
Posted by ion2014 <gi...@git.apache.org>.
Github user ion2014 closed the pull request at:
https://github.com/apache/hawq/pull/1400
---
[GitHub] hawq issue #1400: HAWQ-1674. add cpp compile support for orc_format
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the issue:
https://github.com/apache/hawq/pull/1400
LGTM +1
---