You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2010/05/15 01:45:43 UTC

[jira] Updated: (SOLR-1846) Remove support for (broken) abortOnConfigurationError

     [ https://issues.apache.org/jira/browse/SOLR-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-1846:
---------------------------

    Attachment: SOLR-1846.patch

updated patch to included the above mentioned suggestions for BadIndexSchemaTest ... it's actually a lot easier now that we have SolrTestCaseJ4

As part of this, i also enhanced AbstractPluginLoader to include the getMessage() from the exception it wraps in it's own message -- this made the test easier to write, but also seems like a good idea in general (prior to this patch the exception messages just told you what type of plugin had a problem being initialized, and you had to look at the nested exception to see why it had a problem)

> Remove support for (broken) abortOnConfigurationError
> -----------------------------------------------------
>
>                 Key: SOLR-1846
>                 URL: https://issues.apache.org/jira/browse/SOLR-1846
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>         Attachments: SOLR-1846.patch, SOLR-1846.patch
>
>
> Setting abortOnConfigurationError==false has not worked for some time, and based on a POLL of existing users, no one seems to need/want it, so we should remove support for it completely to make error handling and reporting work more cleanly.
> http://n3.nabble.com/POLL-Users-of-abortOnConfigurationError-tt484030.html#a484030

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: [jira] Updated: (SOLR-1846) Remove support for (broken) abortOnConfigurationError

Posted by Chris Hostetter <ho...@fucit.org>.
Mark: will it cause you cloud merging problems if i commit this?

: Date: Fri, 14 May 2010 19:45:43 -0400 (EDT)
: From: "Hoss Man (JIRA)" <ji...@apache.org>
: Reply-To: dev@lucene.apache.org
: To: dev@lucene.apache.org
: Subject: [jira] Updated: (SOLR-1846) Remove support for (broken)
:     abortOnConfigurationError
: 
: 
:      [ https://issues.apache.org/jira/browse/SOLR-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
: 
: Hoss Man updated SOLR-1846:
: ---------------------------
: 
:     Attachment: SOLR-1846.patch
: 
: updated patch to included the above mentioned suggestions for BadIndexSchemaTest ... it's actually a lot easier now that we have SolrTestCaseJ4
: 
: As part of this, i also enhanced AbstractPluginLoader to include the getMessage() from the exception it wraps in it's own message -- this made the test easier to write, but also seems like a good idea in general (prior to this patch the exception messages just told you what type of plugin had a problem being initialized, and you had to look at the nested exception to see why it had a problem)
: 
: > Remove support for (broken) abortOnConfigurationError
: > -----------------------------------------------------
: >
: >                 Key: SOLR-1846
: >                 URL: https://issues.apache.org/jira/browse/SOLR-1846
: >             Project: Solr
: >          Issue Type: Improvement
: >            Reporter: Hoss Man
: >         Attachments: SOLR-1846.patch, SOLR-1846.patch
: >
: >
: > Setting abortOnConfigurationError==false has not worked for some time, and based on a POLL of existing users, no one seems to need/want it, so we should remove support for it completely to make error handling and reporting work more cleanly.
: > http://n3.nabble.com/POLL-Users-of-abortOnConfigurationError-tt484030.html#a484030
: 
: -- 
: This message is automatically generated by JIRA.
: -
: You can reply to this email to add a comment to the issue online.
: 
: 
: ---------------------------------------------------------------------
: To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
: For additional commands, e-mail: dev-help@lucene.apache.org
: 



-Hoss


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org