You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by djKooks <gi...@git.apache.org> on 2016/09/29 04:28:06 UTC
[GitHub] zeppelin pull request #1472: Add message of localhost:port on script
GitHub user djKooks opened a pull request:
https://github.com/apache/zeppelin/pull/1472
Add message of localhost:port on script
### What is this PR for?
To show the localhost:port number info when running zeppelin.sh script.
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
* Not an issue.
### How should this be tested?
Run ./zeppelin.sh or ./zeppelin_daemon.sh and see the message about localhost is appearing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/djKooks/zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1472.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1472
----
commit fb9fa6c9ac97f8b75bdba2675538f43105cdb970
Author: Dennis Jung <de...@ascentnet.co.jp>
Date: 2016-09-29T04:22:48Z
Add message of localhost:port on script
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1472: Add message of localhost:port on script
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1472
@djKooks Sorry for my late response. I didn't notice, but seems there is already similar feature merged few days ago. Could you please take a look at #1399?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1472: Add message of localhost:port on script
Posted by djKooks <gi...@git.apache.org>.
Github user djKooks closed the pull request at:
https://github.com/apache/zeppelin/pull/1472
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1472: Add message of localhost:port on script
Posted by djKooks <gi...@git.apache.org>.
Github user djKooks commented on the issue:
https://github.com/apache/zeppelin/pull/1472
@AhyoungRyu you're right. Thanks for comments. I just update lines for file check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1472: Add message of localhost:port on script
Posted by djKooks <gi...@git.apache.org>.
Github user djKooks commented on the issue:
https://github.com/apache/zeppelin/pull/1472
@AhyoungRyu No problem~thanks for guide! I'll keep work on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1472: Add message of localhost:port on script
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1472
@djKooks Yeah I just saw the commit right after you pushed. It's not a silly bug :) But the port part should be updated as well. Some users can use other port number not `8080`. Could you check again please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1472: Add message of localhost:port on script
Posted by djKooks <gi...@git.apache.org>.
Github user djKooks commented on the issue:
https://github.com/apache/zeppelin/pull/1472
@AhyoungRyu It looks different. The one in #1399 records ip address in log, but I want to show this during script is running. It seems ok to keep working on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1472: Add message of localhost:port on script
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1472
@djKooks Yeah you're right. I left the comment like that at the first time, I realized that it's different change after checking it again. Sorry for any confusion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1472: Add message of localhost:port on script
Posted by djKooks <gi...@git.apache.org>.
Github user djKooks commented on the issue:
https://github.com/apache/zeppelin/pull/1472
@AhyoungRyu Actually, I was also thinking about whether this commit needs now. I'll drop this issue and maybe look it again after when it seems useful.
Thanks for help.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1472: Add message of localhost:port on script
Posted by djKooks <gi...@git.apache.org>.
Github user djKooks commented on the issue:
https://github.com/apache/zeppelin/pull/1472
@AhyoungRyu Oh, it was my mistake. Sorry for silly bugs.
I just updated script to find public IP.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1472: Add message of localhost:port on script
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1472
@djKooks Sorry for my late response.
Tested again and it works as expected only when I'm using wireless interpreter.
If I connected wired internet, it doesn't print host info as below
```
$ ./bin/zeppelin-daemon.sh restart
Zeppelin stop [ OK ]
Browse :8080 in your browser.
If you are testing on your local computer, use localhost:8080
Zeppelin start [ OK ]
```
Can you check again this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1472: Add message of localhost:port on script
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1472
@djKooks Yeah right. Thanks for your consideration.
And please do not hesitate if you want to contribute to Zeppelin next time. All ppl in the community will help you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1472: Add message of localhost:port on script
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1472
@djKooks Thanks for kind reminder :)
Currently Zeppelin works with "zero-configuration" status. As you know, even if users didn't activate `conf/zeppelin-env.sh.template` or `conf/zeppelin-site.xml.template`, Zeppelin works with default configurations. I think you missed this side. Can you test this patch without `zeppelin-env.sh` and `zeppelin-site.xml` again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1472: Add message of localhost:port on script
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1472
@djKooks And in my personal opinion, I wonder we need to print wireless network address in shell window since it changes depending on the user's network environment. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1472: Add message of localhost:port on script
Posted by djKooks <gi...@git.apache.org>.
Github user djKooks commented on the issue:
https://github.com/apache/zeppelin/pull/1472
@AhyoungRyu Okay. Thanks~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1472: Add message of localhost:port on script
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1472
@djKooks Hi, Is there any issue for installing `xmllint`? I found it in Mac and Linux but I'm not sure if it exists in all of linux and mac. Do you have any idea?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1472: Add message of localhost:port on script
Posted by djKooks <gi...@git.apache.org>.
Github user djKooks commented on the issue:
https://github.com/apache/zeppelin/pull/1472
@AhyoungRyu Sorry for late reply.
I updated scripts to read port number from environment setups. Please look on and let me know if there is any problem on running this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---