You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/10/22 10:54:46 UTC
[GitHub] [incubator-kyuubi] simon824 opened a new pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
simon824 opened a new pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276
### _Why are the changes needed?_
This is a subtask of umbrella issue #KPIP-1
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#issuecomment-950493290
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1276](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ccdec0) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b1cf51a68f6616516676565271504b9835066e60?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1cf51a) will **decrease** coverage by `0.31%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 3ccdec0 differs from pull request most recent head 2b0158d. Consider uploading reports for the commit 2b0158d to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1276 +/- ##
============================================
- Coverage 78.27% 77.96% -0.32%
Complexity 110 110
============================================
Files 177 177
Lines 7081 7131 +50
Branches 871 877 +6
============================================
+ Hits 5543 5560 +17
- Misses 1060 1091 +31
- Partials 478 480 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ala/org/apache/kyuubi/session/SessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL1Nlc3Npb25NYW5hZ2VyLnNjYWxh) | `62.39% <0.00%> (-0.54%)` | :arrow_down: |
| [...apache/kyuubi/server/api/v1/SessionsResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL1Nlc3Npb25zUmVzb3VyY2Uuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...in/scala/org/apache/kyuubi/server/api/v1/dto.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL2R0by5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...g/apache/kyuubi/engine/spark/udf/KDFRegistry.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay91ZGYvS0RGUmVnaXN0cnkuc2NhbGE=) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `89.89% <0.00%> (-1.02%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.11% <0.00%> (+0.02%)` | :arrow_up: |
| [...yuubi/service/authentication/PlainSASLHelper.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL1BsYWluU0FTTEhlbHBlci5zY2FsYQ==) | `86.66% <0.00%> (+0.30%)` | :arrow_up: |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `78.43% <0.00%> (+0.93%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b1cf51a...2b0158d](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#issuecomment-950493290
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1276](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (67a0a8b) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b1cf51a68f6616516676565271504b9835066e60?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1cf51a) will **decrease** coverage by `0.25%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1276 +/- ##
============================================
- Coverage 78.27% 78.02% -0.26%
Complexity 110 110
============================================
Files 177 177
Lines 7081 7126 +45
Branches 871 876 +5
============================================
+ Hits 5543 5560 +17
- Misses 1060 1086 +26
- Partials 478 480 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ala/org/apache/kyuubi/session/SessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL1Nlc3Npb25NYW5hZ2VyLnNjYWxh) | `62.39% <0.00%> (-0.54%)` | :arrow_down: |
| [...apache/kyuubi/server/api/v1/SessionsResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL1Nlc3Npb25zUmVzb3VyY2Uuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...in/scala/org/apache/kyuubi/server/api/v1/dto.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL2R0by5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...g/apache/kyuubi/engine/spark/udf/KDFRegistry.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay91ZGYvS0RGUmVnaXN0cnkuc2NhbGE=) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `89.89% <0.00%> (-1.02%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.11% <0.00%> (+0.02%)` | :arrow_up: |
| [...yuubi/service/authentication/PlainSASLHelper.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL1BsYWluU0FTTEhlbHBlci5zY2FsYQ==) | `86.66% <0.00%> (+0.30%)` | :arrow_up: |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `78.43% <0.00%> (+0.93%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b1cf51a...67a0a8b](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yanghua commented on a change in pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#discussion_r734569155
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/dto.scala
##########
@@ -21,6 +21,17 @@ case class SessionOpenCount(openSessionCount: Int)
case class ExecPoolStatistic(execPoolSize: Int, execPoolActiveCount: Int)
+case class SessionInfoList(sessionList: List[SessionInfo])
+
+case class SessionInfo(
+ user: String,
+ ipAddr: String,
+ createTime: Long,
+ lastAccessTime: Long,
+ lastIdleTime: Long,
+ noOperationTime: Long
+)
+
Review comment:
We may need `handle` as a primary key and `protocol`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yanghua commented on pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#issuecomment-951533425
cc @ulysses-you @turboFei @pan3793 @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#issuecomment-950493290
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1276](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2b0158d) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b1cf51a68f6616516676565271504b9835066e60?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1cf51a) will **decrease** coverage by `0.29%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1276 +/- ##
============================================
- Coverage 78.27% 77.98% -0.30%
Complexity 110 110
============================================
Files 177 177
Lines 7081 7131 +50
Branches 871 877 +6
============================================
+ Hits 5543 5561 +18
- Misses 1060 1091 +31
- Partials 478 479 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ala/org/apache/kyuubi/session/SessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL1Nlc3Npb25NYW5hZ2VyLnNjYWxh) | `62.39% <0.00%> (-0.54%)` | :arrow_down: |
| [...apache/kyuubi/server/api/v1/SessionsResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL1Nlc3Npb25zUmVzb3VyY2Uuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...in/scala/org/apache/kyuubi/server/api/v1/dto.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL2R0by5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...g/apache/kyuubi/engine/spark/udf/KDFRegistry.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay91ZGYvS0RGUmVnaXN0cnkuc2NhbGE=) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.11% <0.00%> (+0.02%)` | :arrow_up: |
| [...yuubi/service/authentication/PlainSASLHelper.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL1BsYWluU0FTTEhlbHBlci5zY2FsYQ==) | `86.66% <0.00%> (+0.30%)` | :arrow_up: |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `78.43% <0.00%> (+0.93%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b1cf51a...2b0158d](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] simon824 commented on a change in pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
simon824 commented on a change in pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#discussion_r735556964
##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/SessionsResourceSuite.scala
##########
@@ -111,4 +111,66 @@ class SessionsResourceSuite extends RestApiBaseSuite {
}
}
+ @Test
+ def testGetSessionList: Unit = {
+ val requestObj = SessionOpenRequest(
+ 1, "admin", "123456", "localhost", Map("testConfig" -> "testValue"))
+
+ RestFrontendServiceSuite.withKyuubiRestServer {
+ (_, _, _) =>
+ var response = target(s"api/v1/sessions")
+ .request(MediaType.APPLICATION_JSON_TYPE)
+ .post(Entity.entity(requestObj, MediaType.APPLICATION_JSON_TYPE))
+
+ // get session list
+ var response2 = target("api/v1/sessions").request().get()
+ assert(200 == response2.getStatus)
+ val sessions1 = response2.readEntity(classOf[SessionList])
+ assert(sessions1.sessionList.nonEmpty)
+
+ // close a opened session
+ val sessionHandle = response.readEntity(classOf[SessionHandle])
+ val serializedSessionHandle = s"${sessionHandle.identifier.publicId}|" +
+ s"${sessionHandle.identifier.secretId}|${sessionHandle.protocol.getValue}"
+ response = target(s"api/v1/sessions/$serializedSessionHandle").request().delete()
+ assert(200 == response.getStatus)
+
+ // get session list again
+ response2 = target("api/v1/sessions").request().get()
+ assert(200 == response2.getStatus)
+ val sessions2 = response2.readEntity(classOf[SessionList])
+ assert(sessions2.sessionList.isEmpty)
+ }
+ }
+
+ @Test
+ def testGetSessionDetail: Unit = {
+ val requestObj = SessionOpenRequest(
+ 1, "admin", "123456", "localhost", Map("testConfig" -> "testValue"))
+
+ RestFrontendServiceSuite.withKyuubiRestServer {
+ (_, _, _) =>
+ var response = target(s"api/v1/sessions")
+ .request(MediaType.APPLICATION_JSON_TYPE)
+ .post(Entity.entity(requestObj, MediaType.APPLICATION_JSON_TYPE))
+
+ val sessionHandle = response.readEntity(classOf[SessionHandle])
+ val serializedSessionHandle = s"${sessionHandle.identifier.publicId}|" +
+ s"${sessionHandle.identifier.secretId}|${sessionHandle.protocol.getValue}"
+
+ // get session detail
+ response = target(s"api/v1/sessions/$serializedSessionHandle").request().get()
+ assert(200 == response.getStatus)
+ var sessions = response.readEntity(classOf[SessionDetail])
+ assert(sessions.configs.nonEmpty)
+
+ // close a opened session
+ response = target(s"api/v1/sessions/$serializedSessionHandle").request().delete()
+ assert(200 == response.getStatus)
+
+ // get session detail again
+ response = target(s"api/v1/sessions/$serializedSessionHandle").request().get()
+ assert(200 != response.getStatus)
Review comment:
500 , because failed to get the sessionHandle , maybe should return an empty sessionDetail here？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#issuecomment-950493290
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1276](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f6b5b54) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b1cf51a68f6616516676565271504b9835066e60?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1cf51a) will **decrease** coverage by `0.21%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1276 +/- ##
============================================
- Coverage 78.27% 78.06% -0.22%
Complexity 110 110
============================================
Files 177 177
Lines 7081 7108 +27
Branches 871 873 +2
============================================
+ Hits 5543 5549 +6
- Misses 1060 1080 +20
- Partials 478 479 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ala/org/apache/kyuubi/session/SessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL1Nlc3Npb25NYW5hZ2VyLnNjYWxh) | `62.39% <0.00%> (-0.54%)` | :arrow_down: |
| [...apache/kyuubi/server/api/v1/SessionsResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL1Nlc3Npb25zUmVzb3VyY2Uuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...in/scala/org/apache/kyuubi/server/api/v1/dto.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL2R0by5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `89.89% <0.00%> (-1.02%)` | :arrow_down: |
| [...g/apache/kyuubi/engine/spark/udf/KDFRegistry.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay91ZGYvS0RGUmVnaXN0cnkuc2NhbGE=) | `100.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b1cf51a...f6b5b54](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yanghua commented on a change in pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#discussion_r735657268
##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/SessionsResourceSuite.scala
##########
@@ -111,4 +111,66 @@ class SessionsResourceSuite extends RestApiBaseSuite {
}
}
+ @Test
+ def testGetSessionList: Unit = {
+ val requestObj = SessionOpenRequest(
+ 1, "admin", "123456", "localhost", Map("testConfig" -> "testValue"))
+
+ RestFrontendServiceSuite.withKyuubiRestServer {
+ (_, _, _) =>
+ var response = target(s"api/v1/sessions")
+ .request(MediaType.APPLICATION_JSON_TYPE)
+ .post(Entity.entity(requestObj, MediaType.APPLICATION_JSON_TYPE))
+
+ // get session list
+ var response2 = target("api/v1/sessions").request().get()
+ assert(200 == response2.getStatus)
+ val sessions1 = response2.readEntity(classOf[SessionList])
+ assert(sessions1.sessionList.nonEmpty)
+
+ // close a opened session
+ val sessionHandle = response.readEntity(classOf[SessionHandle])
+ val serializedSessionHandle = s"${sessionHandle.identifier.publicId}|" +
+ s"${sessionHandle.identifier.secretId}|${sessionHandle.protocol.getValue}"
+ response = target(s"api/v1/sessions/$serializedSessionHandle").request().delete()
+ assert(200 == response.getStatus)
+
+ // get session list again
+ response2 = target("api/v1/sessions").request().get()
+ assert(200 == response2.getStatus)
+ val sessions2 = response2.readEntity(classOf[SessionList])
+ assert(sessions2.sessionList.isEmpty)
+ }
+ }
+
+ @Test
+ def testGetSessionDetail: Unit = {
+ val requestObj = SessionOpenRequest(
+ 1, "admin", "123456", "localhost", Map("testConfig" -> "testValue"))
+
+ RestFrontendServiceSuite.withKyuubiRestServer {
+ (_, _, _) =>
+ var response = target(s"api/v1/sessions")
+ .request(MediaType.APPLICATION_JSON_TYPE)
+ .post(Entity.entity(requestObj, MediaType.APPLICATION_JSON_TYPE))
+
+ val sessionHandle = response.readEntity(classOf[SessionHandle])
+ val serializedSessionHandle = s"${sessionHandle.identifier.publicId}|" +
+ s"${sessionHandle.identifier.secretId}|${sessionHandle.protocol.getValue}"
+
+ // get session detail
+ response = target(s"api/v1/sessions/$serializedSessionHandle").request().get()
+ assert(200 == response.getStatus)
+ var sessions = response.readEntity(classOf[SessionDetail])
+ assert(sessions.configs.nonEmpty)
+
+ // close a opened session
+ response = target(s"api/v1/sessions/$serializedSessionHandle").request().delete()
+ assert(200 == response.getStatus)
+
+ // get session detail again
+ response = target(s"api/v1/sessions/$serializedSessionHandle").request().get()
+ assert(200 != response.getStatus)
Review comment:
500, is not a good status code here. IMO, from a resource point of view, 404 is a better choice. We want to fetch a detailed session resource, but there is nothing. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yanghua commented on a change in pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#discussion_r735371056
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/dto.scala
##########
@@ -17,10 +17,25 @@
package org.apache.kyuubi.server.api.v1
+import org.apache.kyuubi.session.SessionHandle
+
case class SessionOpenCount(openSessionCount: Int)
case class ExecPoolStatistic(execPoolSize: Int, execPoolActiveCount: Int)
+case class SessionInfoList(sessionList: List[SessionInfo])
+
+case class SessionInfo(
+ user: String,
+ ipAddr: String,
+ createTime: Long,
+ sessionHandle: SessionHandle,
+ lastAccessTime: Long = 0L,
+ lastIdleTime: Long = 0L,
+ noOperationTime: Long = 0L,
+ configs: Map[String, String] = Map()
Review comment:
Not sure, if the overview and detailed view share the same model, it may make users confused (about the default value). IMO, a better way is to distinguish them with the different views so that the overview could hide these fields. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yanghua commented on a change in pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions and /${version}/sessions/{sessionHandle}
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#discussion_r736290015
##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/SessionsResourceSuite.scala
##########
@@ -111,4 +111,67 @@ class SessionsResourceSuite extends RestApiBaseSuite {
}
}
+ @Test
Review comment:
no special reason. IMO, we can move to the scala test style for the unified purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yanghua commented on a change in pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions and /${version}/sessions/{sessionHandle}
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#discussion_r736615114
##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/SessionsResourceSuite.scala
##########
@@ -111,4 +111,67 @@ class SessionsResourceSuite extends RestApiBaseSuite {
}
}
+ @Test
Review comment:
Will file a ticket to track this improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yanghua commented on a change in pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#discussion_r735107354
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/dto.scala
##########
@@ -21,6 +21,17 @@ case class SessionOpenCount(openSessionCount: Int)
case class ExecPoolStatistic(execPoolSize: Int, execPoolActiveCount: Int)
+case class SessionInfoList(sessionList: List[SessionInfo])
+
+case class SessionInfo(
+ user: String,
+ ipAddr: String,
+ createTime: Long,
+ lastAccessTime: Long,
+ lastIdleTime: Long,
+ noOperationTime: Long
+)
+
Review comment:
IMO, we need the session handle to query a detailed session's information. Considering the `sessions` API is used to provide information for a list element in a web page, while when we click a `detail` button of one session, we may need to use the `handle` to request a detailed session, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#issuecomment-950493290
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1276](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f538376) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b1cf51a68f6616516676565271504b9835066e60?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1cf51a) will **decrease** coverage by `0.31%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head f538376 differs from pull request most recent head 2b0158d. Consider uploading reports for the commit 2b0158d to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1276 +/- ##
============================================
- Coverage 78.27% 77.96% -0.32%
Complexity 110 110
============================================
Files 177 177
Lines 7081 7131 +50
Branches 871 877 +6
============================================
+ Hits 5543 5560 +17
- Misses 1060 1091 +31
- Partials 478 480 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ala/org/apache/kyuubi/session/SessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL1Nlc3Npb25NYW5hZ2VyLnNjYWxh) | `62.39% <0.00%> (-0.54%)` | :arrow_down: |
| [...apache/kyuubi/server/api/v1/SessionsResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL1Nlc3Npb25zUmVzb3VyY2Uuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...in/scala/org/apache/kyuubi/server/api/v1/dto.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL2R0by5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...g/apache/kyuubi/engine/spark/udf/KDFRegistry.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay91ZGYvS0RGUmVnaXN0cnkuc2NhbGE=) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `89.89% <0.00%> (-1.02%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.11% <0.00%> (+0.02%)` | :arrow_up: |
| [...yuubi/service/authentication/PlainSASLHelper.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL1BsYWluU0FTTEhlbHBlci5zY2FsYQ==) | `86.66% <0.00%> (+0.30%)` | :arrow_up: |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `78.43% <0.00%> (+0.93%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b1cf51a...2b0158d](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#issuecomment-950493290
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1276](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2b0158d) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b1cf51a68f6616516676565271504b9835066e60?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1cf51a) will **decrease** coverage by `0.29%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 2b0158d differs from pull request most recent head f82958d. Consider uploading reports for the commit f82958d to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1276 +/- ##
============================================
- Coverage 78.27% 77.98% -0.30%
Complexity 110 110
============================================
Files 177 177
Lines 7081 7131 +50
Branches 871 877 +6
============================================
+ Hits 5543 5561 +18
- Misses 1060 1091 +31
- Partials 478 479 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ala/org/apache/kyuubi/session/SessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL1Nlc3Npb25NYW5hZ2VyLnNjYWxh) | `62.39% <0.00%> (-0.54%)` | :arrow_down: |
| [...apache/kyuubi/server/api/v1/SessionsResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL1Nlc3Npb25zUmVzb3VyY2Uuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...in/scala/org/apache/kyuubi/server/api/v1/dto.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL2R0by5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...g/apache/kyuubi/engine/spark/udf/KDFRegistry.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay91ZGYvS0RGUmVnaXN0cnkuc2NhbGE=) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.11% <0.00%> (+0.02%)` | :arrow_up: |
| [...yuubi/service/authentication/PlainSASLHelper.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL1BsYWluU0FTTEhlbHBlci5zY2FsYQ==) | `86.66% <0.00%> (+0.30%)` | :arrow_up: |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `78.43% <0.00%> (+0.93%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b1cf51a...f82958d](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] simon824 commented on a change in pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
simon824 commented on a change in pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#discussion_r735222047
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/dto.scala
##########
@@ -21,6 +21,17 @@ case class SessionOpenCount(openSessionCount: Int)
case class ExecPoolStatistic(execPoolSize: Int, execPoolActiveCount: Int)
+case class SessionInfoList(sessionList: List[SessionInfo])
+
+case class SessionInfo(
+ user: String,
+ ipAddr: String,
+ createTime: Long,
+ lastAccessTime: Long,
+ lastIdleTime: Long,
+ noOperationTime: Long
+)
+
Review comment:
Yes, I added the api `/${version}/sessions/${identifier}`, please review this again when free, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yanghua commented on a change in pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#discussion_r735527247
##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/SessionsResourceSuite.scala
##########
@@ -111,4 +111,66 @@ class SessionsResourceSuite extends RestApiBaseSuite {
}
}
+ @Test
+ def testGetSessionList: Unit = {
+ val requestObj = SessionOpenRequest(
+ 1, "admin", "123456", "localhost", Map("testConfig" -> "testValue"))
+
+ RestFrontendServiceSuite.withKyuubiRestServer {
+ (_, _, _) =>
+ var response = target(s"api/v1/sessions")
+ .request(MediaType.APPLICATION_JSON_TYPE)
+ .post(Entity.entity(requestObj, MediaType.APPLICATION_JSON_TYPE))
+
+ // get session list
+ var response2 = target("api/v1/sessions").request().get()
+ assert(200 == response2.getStatus)
+ val sessions1 = response2.readEntity(classOf[SessionList])
+ assert(sessions1.sessionList.nonEmpty)
+
+ // close a opened session
+ val sessionHandle = response.readEntity(classOf[SessionHandle])
+ val serializedSessionHandle = s"${sessionHandle.identifier.publicId}|" +
+ s"${sessionHandle.identifier.secretId}|${sessionHandle.protocol.getValue}"
+ response = target(s"api/v1/sessions/$serializedSessionHandle").request().delete()
+ assert(200 == response.getStatus)
+
+ // get session list again
+ response2 = target("api/v1/sessions").request().get()
+ assert(200 == response2.getStatus)
+ val sessions2 = response2.readEntity(classOf[SessionList])
+ assert(sessions2.sessionList.isEmpty)
+ }
+ }
+
+ @Test
+ def testGetSessionDetail: Unit = {
+ val requestObj = SessionOpenRequest(
+ 1, "admin", "123456", "localhost", Map("testConfig" -> "testValue"))
+
+ RestFrontendServiceSuite.withKyuubiRestServer {
+ (_, _, _) =>
+ var response = target(s"api/v1/sessions")
+ .request(MediaType.APPLICATION_JSON_TYPE)
+ .post(Entity.entity(requestObj, MediaType.APPLICATION_JSON_TYPE))
+
+ val sessionHandle = response.readEntity(classOf[SessionHandle])
+ val serializedSessionHandle = s"${sessionHandle.identifier.publicId}|" +
+ s"${sessionHandle.identifier.secretId}|${sessionHandle.protocol.getValue}"
+
+ // get session detail
+ response = target(s"api/v1/sessions/$serializedSessionHandle").request().get()
+ assert(200 == response.getStatus)
+ var sessions = response.readEntity(classOf[SessionDetail])
+ assert(sessions.configs.nonEmpty)
+
+ // close a opened session
+ response = target(s"api/v1/sessions/$serializedSessionHandle").request().delete()
+ assert(200 == response.getStatus)
+
+ // get session detail again
+ response = target(s"api/v1/sessions/$serializedSessionHandle").request().get()
+ assert(200 != response.getStatus)
Review comment:
Did you check the actual status code? What it is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yanghua commented on a change in pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#discussion_r735270997
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/dto.scala
##########
@@ -21,6 +21,17 @@ case class SessionOpenCount(openSessionCount: Int)
case class ExecPoolStatistic(execPoolSize: Int, execPoolActiveCount: Int)
+case class SessionInfoList(sessionList: List[SessionInfo])
+
+case class SessionInfo(
+ user: String,
+ ipAddr: String,
+ createTime: Long,
+ lastAccessTime: Long,
+ lastIdleTime: Long,
+ noOperationTime: Long
+)
+
Review comment:
I mean we also need the `handle` to be hosted in `SessionInfo`, otherwise, how can we get the handle for each `session`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] simon824 commented on a change in pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
simon824 commented on a change in pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#discussion_r735418572
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/dto.scala
##########
@@ -17,10 +17,25 @@
package org.apache.kyuubi.server.api.v1
+import org.apache.kyuubi.session.SessionHandle
+
case class SessionOpenCount(openSessionCount: Int)
case class ExecPoolStatistic(execPoolSize: Int, execPoolActiveCount: Int)
+case class SessionInfoList(sessionList: List[SessionInfo])
+
+case class SessionInfo(
+ user: String,
+ ipAddr: String,
+ createTime: Long,
+ sessionHandle: SessionHandle,
+ lastAccessTime: Long = 0L,
+ lastIdleTime: Long = 0L,
+ noOperationTime: Long = 0L,
+ configs: Map[String, String] = Map()
Review comment:
Sounds good, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] simon824 commented on a change in pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
simon824 commented on a change in pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#discussion_r734438610
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/dto.scala
##########
@@ -21,6 +21,17 @@ case class SessionOpenCount(openSessionCount: Int)
case class ExecPoolStatistic(execPoolSize: Int, execPoolActiveCount: Int)
+case class SessionInfoList(sessionList: List[SessionInfo])
+
+case class SessionInfo(
+ user: String,
+ ipAddr: String,
+ createTime: Long,
+ lastAccessTime: Long,
+ lastIdleTime: Long,
+ noOperationTime: Long
+)
+
Review comment:
cc @yanghua , I am not sure if it's enough for this api to return these sesssion information. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#issuecomment-950493290
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1276](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f82958d) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b1cf51a68f6616516676565271504b9835066e60?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1cf51a) will **decrease** coverage by `0.30%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1276 +/- ##
============================================
- Coverage 78.27% 77.97% -0.31%
Complexity 110 110
============================================
Files 177 177
Lines 7081 7137 +56
Branches 871 877 +6
============================================
+ Hits 5543 5565 +22
- Misses 1060 1093 +33
- Partials 478 479 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ala/org/apache/kyuubi/session/SessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL1Nlc3Npb25NYW5hZ2VyLnNjYWxh) | `62.39% <0.00%> (-0.54%)` | :arrow_down: |
| [...apache/kyuubi/server/api/v1/SessionsResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL1Nlc3Npb25zUmVzb3VyY2Uuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...in/scala/org/apache/kyuubi/server/api/v1/dto.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL2R0by5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...g/apache/kyuubi/engine/spark/udf/KDFRegistry.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay91ZGYvS0RGUmVnaXN0cnkuc2NhbGE=) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.11% <0.00%> (+0.02%)` | :arrow_up: |
| [...yuubi/service/authentication/PlainSASLHelper.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL1BsYWluU0FTTEhlbHBlci5zY2FsYQ==) | `86.66% <0.00%> (+0.30%)` | :arrow_up: |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `78.43% <0.00%> (+0.93%)` | :arrow_up: |
| [...g/apache/kyuubi/server/KinitAuxiliaryService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS2luaXRBdXhpbGlhcnlTZXJ2aWNlLnNjYWxh) | `66.66% <0.00%> (+1.96%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b1cf51a...f82958d](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] simon824 commented on a change in pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
simon824 commented on a change in pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#discussion_r735302996
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/dto.scala
##########
@@ -21,6 +21,17 @@ case class SessionOpenCount(openSessionCount: Int)
case class ExecPoolStatistic(execPoolSize: Int, execPoolActiveCount: Int)
+case class SessionInfoList(sessionList: List[SessionInfo])
+
+case class SessionInfo(
+ user: String,
+ ipAddr: String,
+ createTime: Long,
+ lastAccessTime: Long,
+ lastIdleTime: Long,
+ noOperationTime: Long
+)
+
Review comment:
Get it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yanghua commented on a change in pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#discussion_r735485336
##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/SessionsResourceSuite.scala
##########
@@ -111,4 +111,36 @@ class SessionsResourceSuite extends RestApiBaseSuite {
}
}
+ @Test
+ def testGetSession: Unit = {
Review comment:
`testGetSessionList` or `testGetSessions` looks better? And also verify get a detailed session info?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] simon824 commented on a change in pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
simon824 commented on a change in pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#discussion_r734912044
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/dto.scala
##########
@@ -21,6 +21,17 @@ case class SessionOpenCount(openSessionCount: Int)
case class ExecPoolStatistic(execPoolSize: Int, execPoolActiveCount: Int)
+case class SessionInfoList(sessionList: List[SessionInfo])
+
+case class SessionInfo(
+ user: String,
+ ipAddr: String,
+ createTime: Long,
+ lastAccessTime: Long,
+ lastIdleTime: Long,
+ noOperationTime: Long
+)
+
Review comment:
This api is for listing all sessions, does it need `handle`?
```
/${version}/sessions
mapping: none
desc: get all the session list hosted in SessionManager
method: GET
params: none
returns session list overview of Session
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#issuecomment-950493290
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1276](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2b0158d) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b1cf51a68f6616516676565271504b9835066e60?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1cf51a) will **decrease** coverage by `0.29%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 2b0158d differs from pull request most recent head 3fa9e95. Consider uploading reports for the commit 3fa9e95 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1276 +/- ##
============================================
- Coverage 78.27% 77.98% -0.30%
Complexity 110 110
============================================
Files 177 177
Lines 7081 7131 +50
Branches 871 877 +6
============================================
+ Hits 5543 5561 +18
- Misses 1060 1091 +31
- Partials 478 479 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ala/org/apache/kyuubi/session/SessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL1Nlc3Npb25NYW5hZ2VyLnNjYWxh) | `62.39% <0.00%> (-0.54%)` | :arrow_down: |
| [...apache/kyuubi/server/api/v1/SessionsResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL1Nlc3Npb25zUmVzb3VyY2Uuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...in/scala/org/apache/kyuubi/server/api/v1/dto.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL2R0by5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...g/apache/kyuubi/engine/spark/udf/KDFRegistry.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay91ZGYvS0RGUmVnaXN0cnkuc2NhbGE=) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.11% <0.00%> (+0.02%)` | :arrow_up: |
| [...yuubi/service/authentication/PlainSASLHelper.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL1BsYWluU0FTTEhlbHBlci5zY2FsYQ==) | `86.66% <0.00%> (+0.30%)` | :arrow_up: |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `78.43% <0.00%> (+0.93%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b1cf51a...3fa9e95](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you closed pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions and /${version}/sessions/{sessionHandle}
Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#issuecomment-950493290
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1276](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f6b5b54) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b1cf51a68f6616516676565271504b9835066e60?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1cf51a) will **decrease** coverage by `0.21%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head f6b5b54 differs from pull request most recent head 67a0a8b. Consider uploading reports for the commit 67a0a8b to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1276 +/- ##
============================================
- Coverage 78.27% 78.06% -0.22%
Complexity 110 110
============================================
Files 177 177
Lines 7081 7108 +27
Branches 871 873 +2
============================================
+ Hits 5543 5549 +6
- Misses 1060 1080 +20
- Partials 478 479 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ala/org/apache/kyuubi/session/SessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL1Nlc3Npb25NYW5hZ2VyLnNjYWxh) | `62.39% <0.00%> (-0.54%)` | :arrow_down: |
| [...apache/kyuubi/server/api/v1/SessionsResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL1Nlc3Npb25zUmVzb3VyY2Uuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...in/scala/org/apache/kyuubi/server/api/v1/dto.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL2R0by5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `89.89% <0.00%> (-1.02%)` | :arrow_down: |
| [...g/apache/kyuubi/engine/spark/udf/KDFRegistry.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay91ZGYvS0RGUmVnaXN0cnkuc2NhbGE=) | `100.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b1cf51a...67a0a8b](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yanghua commented on a change in pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#discussion_r735484631
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/SessionsResource.scala
##########
@@ -30,6 +32,31 @@ import org.apache.kyuubi.session.SessionHandle
@Produces(Array(MediaType.APPLICATION_JSON))
private[v1] class SessionsResource extends ApiRequestContext {
+ @GET
+ def sessionInfoList(): SessionList = {
+ SessionList(
+ backendService.sessionManager.getSessionList().asScala.map {
+ case (handle, session) =>
+ SessionOverview(session.user, session.ipAddress, session.createTime, handle)
+ }.toList
+ )
+ }
+
+ @GET
+ @Path("{sessionHandle}")
+ def sessionInfo(@PathParam("sessionHandle") sessionHandleStr: String): SessionDetails = {
+ val splitSessionHandle = sessionHandleStr.split("\\|")
+ val handleIdentifier = new HandleIdentifier(
+ UUID.fromString(splitSessionHandle(0)), UUID.fromString(splitSessionHandle(1)))
+ val protocolVersion = TProtocolVersion.findByValue(splitSessionHandle(2).toInt)
+ val sessionHandle = new SessionHandle(handleIdentifier, protocolVersion)
+
+ val session = backendService.sessionManager.getSession(sessionHandle)
+
+ SessionDetails(session.user, session.ipAddress, session.createTime, sessionHandle,
Review comment:
`SessionDetail` sounds better?
##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/SessionsResourceSuite.scala
##########
@@ -111,4 +111,36 @@ class SessionsResourceSuite extends RestApiBaseSuite {
}
}
+ @Test
+ def testGetSession: Unit = {
Review comment:
`testGetSessionList` or `testGetSessions` and also add a test to verify get a detailed session info?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions and /${version}/sessions/{sessionHandle}
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#discussion_r736294317
##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/SessionsResourceSuite.scala
##########
@@ -111,4 +111,67 @@ class SessionsResourceSuite extends RestApiBaseSuite {
}
}
+ @Test
Review comment:
I think we disabled `maven-surefire-plugin`, seems that Junit won't be triggered?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions and /${version}/sessions/{sessionHandle}
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#discussion_r736294317
##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/SessionsResourceSuite.scala
##########
@@ -111,4 +111,67 @@ class SessionsResourceSuite extends RestApiBaseSuite {
}
}
+ @Test
Review comment:
I think we disabled `maven-surefire-plugin`, seems that JUnit won't be triggered?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] simon824 commented on pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions and /${version}/sessions/{sessionHandle}
Posted by GitBox <gi...@apache.org>.
simon824 commented on pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#issuecomment-951555121
> LGTM. @simon824 Thanks for your patient. BTW, considering you have implemented two APIs, would you please change the title of the PR and issue?
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions and /${version}/sessions/{sessionHandle}
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#issuecomment-951650193
thank you @simon824 @yanghua and @yaooqinn , merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions and /${version}/sessions/{sessionHandle}
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#discussion_r736244757
##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/SessionsResourceSuite.scala
##########
@@ -111,4 +111,67 @@ class SessionsResourceSuite extends RestApiBaseSuite {
}
}
+ @Test
Review comment:
BTW, can we move the java test to scala test in a new PR ? or is there some history reason ? @simon824 @yanghua
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1276: [KYUUBI #1275] Implement api: /${version}/sessions
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1276:
URL: https://github.com/apache/incubator-kyuubi/pull/1276#issuecomment-950493290
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1276](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f538376) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b1cf51a68f6616516676565271504b9835066e60?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1cf51a) will **decrease** coverage by `0.31%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1276 +/- ##
============================================
- Coverage 78.27% 77.96% -0.32%
Complexity 110 110
============================================
Files 177 177
Lines 7081 7131 +50
Branches 871 877 +6
============================================
+ Hits 5543 5560 +17
- Misses 1060 1091 +31
- Partials 478 480 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ala/org/apache/kyuubi/session/SessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL1Nlc3Npb25NYW5hZ2VyLnNjYWxh) | `62.39% <0.00%> (-0.54%)` | :arrow_down: |
| [...apache/kyuubi/server/api/v1/SessionsResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL1Nlc3Npb25zUmVzb3VyY2Uuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...in/scala/org/apache/kyuubi/server/api/v1/dto.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL2R0by5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...g/apache/kyuubi/engine/spark/udf/KDFRegistry.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay91ZGYvS0RGUmVnaXN0cnkuc2NhbGE=) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `89.89% <0.00%> (-1.02%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.11% <0.00%> (+0.02%)` | :arrow_up: |
| [...yuubi/service/authentication/PlainSASLHelper.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL1BsYWluU0FTTEhlbHBlci5zY2FsYQ==) | `86.66% <0.00%> (+0.30%)` | :arrow_up: |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `78.43% <0.00%> (+0.93%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b1cf51a...f538376](https://codecov.io/gh/apache/incubator-kyuubi/pull/1276?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org