You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by sejunra <gi...@git.apache.org> on 2016/01/15 09:37:27 UTC
[GitHub] incubator-zeppelin pull request: Added Kerberos documentation
GitHub user sejunra opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/640
Added Kerberos documentation
### What is this PR for?
Added Kerberos setup with Zeppelin
### What type of PR is it?
Documentation
### Is there a relevant Jira issue?
No
### How should this be tested?
Check out the website
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sejunra/incubator-zeppelin docs/kerberos
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/640.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #640
----
commit cac87ea8e55b7aa8f9bfa09a8ccb6786431bd935
Author: Sejun Ra <se...@nflabs.com>
Date: 2016-01-15T08:33:03Z
Added Kerberos documentation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added Kerberos documentation
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/640
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added Kerberos documentation
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/640#issuecomment-184046593
@bzz I've addressed and pushed them : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added Kerberos documentation
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/640#issuecomment-183982372
@AhyoungRyu thank you for a thoughtful review!
If you have a spare moment and could contribute those 2 changes, please do, as it might really speed merging this on a lot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added Kerberos documentation
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/640#issuecomment-181250941
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added Kerberos documentation
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/640#issuecomment-171986304
Thank you for contribution @sejunra
Right now CI fails on the new file you have added, as it does not have an apache licence header.
```
Unknown Licenses
*******************************
Unapproved licenses:
docs/manual/conf_kerberos.md
*******************************
```
Would you care for adding one please?
See this [example](https://raw.githubusercontent.com/apache/incubator-zeppelin/master/docs/manual/notebookashomepage.md) for a licence header in docs, right before `{% include JB/setup %}
`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added Kerberos documentation
Posted by sejunra <gi...@git.apache.org>.
Github user sejunra commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/640#issuecomment-178438976
sorry. thought i already pushed. done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added Kerberos documentation
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/640#issuecomment-178405245
@sejunra any update?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added Kerberos documentation
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/640#issuecomment-172225220
@sejunra
The docs/interpreter/spark.md supposed to have configurations for Spark Interpreter. And this document have instruction for configuring SparkInterpreter with Kerberos enabled yarn cluster. Not applied to any other interpreter nor Zeppelin server daemon. I think docs/interpreter/spark.md natural place to be.
Then the duplication that this documents made (instruction for SPARK_HOME and HADOOP_CONF_DIR) also can be removed. And user can see all necessary information in a single place.
It's up to you, but i suggest move it into docs/interpreter/spark.md or at least update doc to make it clear that the instruction is for only Spark interpreter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added Kerberos documentation
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/640#issuecomment-184076341
Thank you so much for taking care!
Merging this guy if there is no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added Kerberos documentation
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/640#issuecomment-184077416
Let's merge! : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added Kerberos documentation
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/640#issuecomment-181183797
looks good to me - @AhyoungRyu @Leemoonsoo ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added Kerberos documentation
Posted by sejunra <gi...@git.apache.org>.
Github user sejunra commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/640#issuecomment-180173515
Made all changes as requested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added Kerberos documentation
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/640#issuecomment-172004733
Thanks for the documentation.
While the documentation is specific for Spark Interpreter, why not adding it under /docs/interpreter/spark.md ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added Kerberos documentation
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/640#issuecomment-181280614
I left some comments in this file. Except them, LGTM! : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added Kerberos documentation
Posted by sejunra <gi...@git.apache.org>.
Github user sejunra commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/640#issuecomment-172171295
@Leemoonsoo kept it on manual instead of your recommended /interpreter folder as it made more sense under /manual which is more how-tos and not related to interpreters (though it's specific to spark). If you feel strongly about the /interpreter location, I can move it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---