You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2013/01/21 22:41:17 UTC

svn commit: r1436635 - /lucene/dev/branches/lucene4547/lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextDocValuesFormat.java

Author: rmuir
Date: Mon Jan 21 21:41:17 2013
New Revision: 1436635

URL: http://svn.apache.org/viewvc?rev=1436635&view=rev
Log:
nuke nocommits

Modified:
    lucene/dev/branches/lucene4547/lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextDocValuesFormat.java

Modified: lucene/dev/branches/lucene4547/lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextDocValuesFormat.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene4547/lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextDocValuesFormat.java?rev=1436635&r1=1436634&r2=1436635&view=diff
==============================================================================
--- lucene/dev/branches/lucene4547/lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextDocValuesFormat.java (original)
+++ lucene/dev/branches/lucene4547/lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextDocValuesFormat.java Mon Jan 21 21:41:17 2013
@@ -135,8 +135,7 @@ public class SimpleTextDocValuesFormat e
    *  the reader can just scan this file when it opens, skipping over the data blocks
    *  and saving the offset/etc for each field. 
    */
-  // nocommit not public
-  public static class SimpleTextDocValuesWriter extends DocValuesConsumer {
+  static class SimpleTextDocValuesWriter extends DocValuesConsumer {
     final IndexOutput data;
     final BytesRef scratch = new BytesRef();
     final int numDocs;
@@ -371,17 +370,10 @@ public class SimpleTextDocValuesFormat e
     }
   };
 
-  // nocommit once we do "in ram cache of direct source"
-  // ... and hopeuflly under SCR control ... then if app
-  // asks for direct soruce but it was already cached in ram
-  // ... we should use the ram cached one!  we don't do this
-  // correctly today ...
-
   // nocommit make sure we test "all docs have 0 value",
   // "all docs have empty BytesREf"
 
-  // nocommit not public
-  public static class SimpleTextDocValuesReader extends DocValuesProducer {
+  static class SimpleTextDocValuesReader extends DocValuesProducer {
 
     static class OneField {
       FieldInfo fieldInfo;