You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@creadur.apache.org by "Claudenw (via GitHub)" <gi...@apache.org> on 2025/06/14 23:15:30 UTC
[PR] Fix poms [creadur-rat]
Claudenw opened a new pull request, #478:
URL: https://github.com/apache/creadur-rat/pull/478
This change fixes some issues with building RAT starting from a clean slate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-475: Fix poms and module issues in order to start with RAT from a clean slate [creadur-rat]
Posted by "ottlinger (via GitHub)" <gi...@apache.org>.
ottlinger commented on code in PR #478:
URL: https://github.com/apache/creadur-rat/pull/478#discussion_r2147526337
##########
pom.xml:
##########
@@ -85,11 +86,11 @@ agnostic home for software distribution comprehension and audit tools.
<artifactId>apache-rat-core</artifactId>
<version>${project.version}</version>
</dependency>
- <dependency>
- <groupId>org.apache.rat</groupId>
- <artifactId>apache-rat-testdata</artifactId>
- <version>${project.version}</version>
- </dependency>
+<!-- <dependency>-->
Review Comment:
Could we remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-379, RAT-475: Fix poms and module issues in order to start with RAT from a clean slate [creadur-rat]
Posted by "Claudenw (via GitHub)" <gi...@apache.org>.
Claudenw closed pull request #478: RAT-379, RAT-475: Fix poms and module issues in order to start with RAT from a clean slate
URL: https://github.com/apache/creadur-rat/pull/478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-379, RAT-475: Fix poms and module issues in order to start with RAT from a clean slate [creadur-rat]
Posted by "Claudenw (via GitHub)" <gi...@apache.org>.
Claudenw commented on PR #478:
URL: https://github.com/apache/creadur-rat/pull/478#issuecomment-2984984091
closing will not merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-475: Fix poms and module issues in order to start with RAT from a clean slate [creadur-rat]
Posted by "ottlinger (via GitHub)" <gi...@apache.org>.
ottlinger commented on code in PR #478:
URL: https://github.com/apache/creadur-rat/pull/478#discussion_r2147526491
##########
pom.xml:
##########
@@ -856,7 +858,7 @@ agnostic home for software distribution comprehension and audit tools.
<module>apache-rat-tasks</module>
<module>apache-rat</module>
<module>apache-rat-tools</module>
- <module>apache-rat-testdata</module>
+<!-- <module>apache-rat-testdata</module>-->
Review Comment:
This removes the whole submodule from the project? Is that intended?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix poms [creadur-rat]
Posted by "Claudenw (via GitHub)" <gi...@apache.org>.
Claudenw commented on PR #478:
URL: https://github.com/apache/creadur-rat/pull/478#issuecomment-2973330955
@ottlinger I think this change fixes most (all?) of the problems that were found in when starting from a clean build. Please check the issues you encountered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org