You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by susheelks <gi...@git.apache.org> on 2017/01/28 13:44:55 UTC

[GitHub] lucene-solr pull request #147: SOLR-8146 decouple building url list from Clo...

GitHub user susheelks opened a pull request:

    https://github.com/apache/lucene-solr/pull/147

    SOLR-8146 decouple building url list from CloudSolrClient to separate class for\u2026

    I am suggesting to decouple building the url list from CloudSolrClient.sendRequest(..) to a separate class.  The advantage will be the ability to easily write unit test for building the url list part and as we implement more routingRules for querying like query only the same rack replica's / OR query replica's where mem/cpu/disk utilisation is below a threshold can be easily unit tested etc.
    
    I can add more tests if approach looks good. Please review.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/susheelks/lucene-solr SOLR-8146

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/147.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #147
    
----
commit 852aa685cc626a4a03c649895ae5ccbfb0008887
Author: Susheel Kumar <su...@gmail.com>
Date:   2017-01-28T13:33:53Z

    decouple building url list from CloudSolrClient to separate class for better testability

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

[GitHub] lucene-solr pull request: Fix invalid solr.xml creation in SolrOut...

Posted by acmcelwee <gi...@git.apache.org>.
Github user acmcelwee commented on the pull request:

    https://github.com/apache/lucene-solr/pull/147#issuecomment-100101790
  
    The test case that I've just attached only executes if I disable the security manager during the test run. It's not clear to me whether that's normal or not, but if there's a way to make the test work with it enabled, please let me know, and I'll update the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org