You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/09/16 16:16:17 UTC
[GitHub] [cassandra-dtest] ifesdjeen opened a new pull request #161: Fix flaky test: repair_tests/repair_test.py::TestRepair::test_local_d…
ifesdjeen opened a new pull request #161:
URL: https://github.com/apache/cassandra-dtest/pull/161
…c_repair
Patch by Alex Petrov; reviewed by TBD for CASSANDRA-16963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] ifesdjeen merged pull request #161: Fix flaky test: repair_tests/repair_test.py::TestRepair::test_local_d…
Posted by GitBox <gi...@apache.org>.
ifesdjeen merged pull request #161:
URL: https://github.com/apache/cassandra-dtest/pull/161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] maedhroz commented on a change in pull request #161: Fix flaky test: repair_tests/repair_test.py::TestRepair::test_local_d…
Posted by GitBox <gi...@apache.org>.
maedhroz commented on a change in pull request #161:
URL: https://github.com/apache/cassandra-dtest/pull/161#discussion_r710321911
##########
File path: tools/data.py
##########
@@ -17,14 +17,17 @@ def create_c1c2_table(tester, session, read_repair=None):
create_cf(session, 'cf', columns={'c1': 'text', 'c2': 'text'}, read_repair=read_repair)
-def insert_c1c2(session, keys=None, n=None, consistency=ConsistencyLevel.QUORUM):
+def insert_c1c2(session, ks=None, keys=None, n=None, consistency=ConsistencyLevel.QUORUM):
if (keys is None and n is None) or (keys is not None and n is not None):
raise ValueError("Expected exactly one of 'keys' or 'n' arguments to not be None; "
"got keys={keys}, n={n}".format(keys=keys, n=n))
if n:
keys = list(range(n))
- statement = session.prepare("INSERT INTO cf (key, c1, c2) VALUES (?, 'value1', 'value2')")
+ fully_qualified_cf = "cf"
+ if ((ks is not None) and (not ks)):
Review comment:
Doesn't `not ks` mean the string is empty? i.e. This conditional says "ks is not None but it is empty"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] ifesdjeen commented on a change in pull request #161: Fix flaky test: repair_tests/repair_test.py::TestRepair::test_local_d…
Posted by GitBox <gi...@apache.org>.
ifesdjeen commented on a change in pull request #161:
URL: https://github.com/apache/cassandra-dtest/pull/161#discussion_r710492617
##########
File path: tools/data.py
##########
@@ -17,14 +17,17 @@ def create_c1c2_table(tester, session, read_repair=None):
create_cf(session, 'cf', columns={'c1': 'text', 'c2': 'text'}, read_repair=read_repair)
-def insert_c1c2(session, keys=None, n=None, consistency=ConsistencyLevel.QUORUM):
+def insert_c1c2(session, ks=None, keys=None, n=None, consistency=ConsistencyLevel.QUORUM):
if (keys is None and n is None) or (keys is not None and n is not None):
raise ValueError("Expected exactly one of 'keys' or 'n' arguments to not be None; "
"got keys={keys}, n={n}".format(keys=keys, n=n))
if n:
keys = list(range(n))
- statement = session.prepare("INSERT INTO cf (key, c1, c2) VALUES (?, 'value1', 'value2')")
+ fully_qualified_cf = "cf"
+ if ((ks is not None) and (not ks)):
Review comment:
You're right, it should've been a double negation!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] maedhroz commented on a change in pull request #161: Fix flaky test: repair_tests/repair_test.py::TestRepair::test_local_d…
Posted by GitBox <gi...@apache.org>.
maedhroz commented on a change in pull request #161:
URL: https://github.com/apache/cassandra-dtest/pull/161#discussion_r710321911
##########
File path: tools/data.py
##########
@@ -17,14 +17,17 @@ def create_c1c2_table(tester, session, read_repair=None):
create_cf(session, 'cf', columns={'c1': 'text', 'c2': 'text'}, read_repair=read_repair)
-def insert_c1c2(session, keys=None, n=None, consistency=ConsistencyLevel.QUORUM):
+def insert_c1c2(session, ks=None, keys=None, n=None, consistency=ConsistencyLevel.QUORUM):
if (keys is None and n is None) or (keys is not None and n is not None):
raise ValueError("Expected exactly one of 'keys' or 'n' arguments to not be None; "
"got keys={keys}, n={n}".format(keys=keys, n=n))
if n:
keys = list(range(n))
- statement = session.prepare("INSERT INTO cf (key, c1, c2) VALUES (?, 'value1', 'value2')")
+ fully_qualified_cf = "cf"
+ if ((ks is not None) and (not ks)):
Review comment:
Doesn't `not ks` mean the string is empty? i.e. This conditional says "ks is not None but it is empty"
Do we want something like `if ((ks is not None) and ks != ""):` or even `if ((ks is not None) and not(not ks)):`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] maedhroz commented on a change in pull request #161: Fix flaky test: repair_tests/repair_test.py::TestRepair::test_local_d…
Posted by GitBox <gi...@apache.org>.
maedhroz commented on a change in pull request #161:
URL: https://github.com/apache/cassandra-dtest/pull/161#discussion_r710321911
##########
File path: tools/data.py
##########
@@ -17,14 +17,17 @@ def create_c1c2_table(tester, session, read_repair=None):
create_cf(session, 'cf', columns={'c1': 'text', 'c2': 'text'}, read_repair=read_repair)
-def insert_c1c2(session, keys=None, n=None, consistency=ConsistencyLevel.QUORUM):
+def insert_c1c2(session, ks=None, keys=None, n=None, consistency=ConsistencyLevel.QUORUM):
if (keys is None and n is None) or (keys is not None and n is not None):
raise ValueError("Expected exactly one of 'keys' or 'n' arguments to not be None; "
"got keys={keys}, n={n}".format(keys=keys, n=n))
if n:
keys = list(range(n))
- statement = session.prepare("INSERT INTO cf (key, c1, c2) VALUES (?, 'value1', 'value2')")
+ fully_qualified_cf = "cf"
+ if ((ks is not None) and (not ks)):
Review comment:
Doesn't `not ks` mean the string is empty? i.e. This conditional says "ks is not None but it is empty"
Do we want something like `if ((ks is not None) and ks):` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] maedhroz commented on a change in pull request #161: Fix flaky test: repair_tests/repair_test.py::TestRepair::test_local_d…
Posted by GitBox <gi...@apache.org>.
maedhroz commented on a change in pull request #161:
URL: https://github.com/apache/cassandra-dtest/pull/161#discussion_r710321911
##########
File path: tools/data.py
##########
@@ -17,14 +17,17 @@ def create_c1c2_table(tester, session, read_repair=None):
create_cf(session, 'cf', columns={'c1': 'text', 'c2': 'text'}, read_repair=read_repair)
-def insert_c1c2(session, keys=None, n=None, consistency=ConsistencyLevel.QUORUM):
+def insert_c1c2(session, ks=None, keys=None, n=None, consistency=ConsistencyLevel.QUORUM):
if (keys is None and n is None) or (keys is not None and n is not None):
raise ValueError("Expected exactly one of 'keys' or 'n' arguments to not be None; "
"got keys={keys}, n={n}".format(keys=keys, n=n))
if n:
keys = list(range(n))
- statement = session.prepare("INSERT INTO cf (key, c1, c2) VALUES (?, 'value1', 'value2')")
+ fully_qualified_cf = "cf"
+ if ((ks is not None) and (not ks)):
Review comment:
Doesn't `not ks` mean the string is empty? i.e. This conditional says "ks is not None but it is empty"
Do we want something like `if ((ks is not None) and ks != ""):` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org