You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/03 05:18:08 UTC
[GitHub] [spark] imback82 commented on a change in pull request #33618: [SPARK-36381][SQL] Add case sensitive and case insensitive compare for checking column name exist when alter table
imback82 commented on a change in pull request #33618:
URL: https://github.com/apache/spark/pull/33618#discussion_r681440489
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/AlterTableTests.scala
##########
@@ -407,6 +408,65 @@ trait AlterTableTests extends SharedSparkSession {
}
}
+ test("SPARK-36381: Alter add column exist check in case sensitive") {
Review comment:
maybe move this to https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/connector/V2CommandsCaseSensitivitySuite.scala?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org