[jira] [Commented] (NIFI-4629) Non-existing attribute in ControlRate configuration causes NullPointerException

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292410#comment-16292410 ] 

ASF GitHub Bot commented on NIFI-4629:
--------------------------------------

GitHub user mgaido91 opened a pull request:

    https://github.com/apache/nifi/pull/2345

    NIFI-4629: Put flowfiles without the grouping attribute in the default group

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?  N/A
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? N/A
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? N/A
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? N/A
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? N/A
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mgaido91/nifi NIFI-4629

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2345.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2345
    
----
commit 96706c5a48045c967c26fb042559db6466f3681b
Author: Marco Gaido <mg...@hortonworks.com>
Date:   2017-12-15T11:59:16Z

    NIFI-4629: Put flowfiles without the grouping attribute in the default group

----


> Non-existing attribute in ControlRate configuration causes NullPointerException
> -------------------------------------------------------------------------------
>
>                 Key: NIFI-4629
>                 URL: https://issues.apache.org/jira/browse/NIFI-4629
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Configuration, Core UI
>    Affects Versions: 1.4.0
>         Environment: Ubuntu LTS 16.04
> openjdk-8-jre
>            Reporter: Fredrik Sko
>            Priority: Critical
>              Labels: ControlRate, NullPointerException, Processor
>         Attachments: ControlRate-NP.xml
>
>
> When using the ControlRate processor, defining the "Grouping Attribute" with a missing/non-existing attribute name produces NullPointerException errors.
> Processor configuration:
> {quote}
> Rate Control Criteria: flowfile count
> Maximum rate: 10
> Rate Controlled Attributes: (No value set)
> Time Duration: 1 min
> Grouping Attribute: foobar
> {quote}
> ControlRate with the following configuration when sent a flowfile without the attribute {{foobar}} generates the following error:
> bq. ControlRate\[id=dff05b32-015f-1000-db55-5957a9298bab] ControlRate\[id=dff05b32-015f-1000-db55-5957a9298bab] failed to process due to java.lang.NullPointerException; rolling back session: null
> Additionally, the incoming flowfiles now ends up in some "dead" state where I'm unable to even empty the queue.
> A simple template for reproduction is attached.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)