[jira] [Commented] (NIFI-4907) Provenance authorization refactoring

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498059#comment-16498059 ] 

ASF GitHub Bot commented on NIFI-4907:
--------------------------------------

Github user markobean commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2703#discussion_r192413226
  
    --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/controller/ControllerFacade.java ---
    @@ -1359,7 +1363,12 @@ public ProvenanceEventDTO getProvenanceEvent(final Long eventId) {
                 } else {
                     dataAuthorizable = flowController.createLocalDataAuthorizable(event.getComponentId());
                 }
    -            dataAuthorizable.authorize(authorizer, RequestAction.READ, NiFiUserUtils.getNiFiUser(), attributes);
    +            // If not authorized for 'view the data', create only summarized provenance event
    --- End diff --
    
    My only concern with the approach you outlined is the additional authorizations calls to determine "if the user is allowed". What you suggest requires up to 2 additional authorizations per provenance event. Already on busy systems, we have observed authorizing the user to each provenance event as a limiting factor (it can result in provenance becoming unusable).  
    Having said that, unless you think of another approach which would require fewer authorizations calls, I'll proceed as you recommend. I suspect there may be a future JIRA ticket to address the provenance query/authorization impact anyhow; if so, this can be addressed at that time. We won't know for sure if this is a problem until we get the current fix into an appropriately loaded test environment.


> Provenance authorization refactoring
> ------------------------------------
>
>                 Key: NIFI-4907
>                 URL: https://issues.apache.org/jira/browse/NIFI-4907
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.5.0
>            Reporter: Mark Bean
>            Assignee: Mark Bean
>            Priority: Major
>
> Currently, the 'view the data' component policy is too tightly coupled with Provenance queries. The 'query provenance' policy should be the only policy required for viewing Provenance query results. Both 'view the component' and 'view the data' policies should be used to refine the appropriate visibility of event details - but not the event itself.
> 1) Component Visibility
> The authorization of Provenance events is inconsistent with the behavior of the graph. For example, if a user does not have 'view the component' policy, the graph shows this component as a "black box" (no details such as name, UUID, etc.) However, when querying Provenance, this component will show up including the Component Type and the Component Name. This is in effect a violation of the policy. These component details should be obscured in the Provenance event displayed if user does not have the appropriate 'view the component' policy.
> 2) Data Visibility
> For a Provenance query, all events should be visible as long as the user performing the query belongs to the 'query provenance' global policy. As mentioned above, some information about the component may be obscured depending on 'view the component' policy, but the event itself should be visible. Additionally, details of the event (clicking the View Details "i" icon) should only be accessible if the user belongs to the 'view the data' policy for the affected component. If the user is not in the appropriate 'view the data' policy, a popup warning should be displayed indicating the reason details are not visible with more specific detail than the current "Contact the system administrator".
> 3) Lineage Graphs
> As with the Provenance table view recommendation above, the lineage graph should display all events. Currently, if the lineage graph includes an event belonging to a component which the user does not have 'view the data', it is shown on the graph as "UNKNOWN". As with Data Visibility mentioned above, the graph should indicate the event type as long as the user is in the 'view the component'. Subsequent "View Details" on the event should only be visible if the user is in the 'view the data' policy.
> In summary, for Provenance query results and lineage graphs, all events should be shown. Component Name and Component Type information should be conditionally visible depending on the corresponding component policy 'view the component' policy. Event details including Provenance event type and FlowFile information should be conditionally available depending on the corresponding component policy 'view the data'. Inability to display event details should provide feedback to the user indicating the reason.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)