Re: [PR] [SPARK-55121][PYTHON][SS] Add DataStreamReader.name() to Classic PySpark [spark]

["ueshin (via GitHub)" <gi...@apache.org>]

ueshin commented on code in PR #53898:
URL: https://github.com/apache/spark/pull/53898#discussion_r2714563076


##########
python/pyspark/sql/streaming/readwriter.py:
##########
@@ -241,6 +242,52 @@ def options(self, **options: "OptionalPrimitiveType") -> "DataStreamReader":
             self._jreader = self._jreader.option(k, to_str(options[k]))
         return self
 
+    def name(self, source_name: str) -> "DataStreamReader":

Review Comment:
   Scala side marks this as `private[sql]`. Will it be removed soon?



##########
python/pyspark/sql/tests/streaming/test_streaming_reader_name.py:
##########


Review Comment:
   This file should be listed in `dev/sparktestsupport/modules.py`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org