You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by Matt Sicker <bo...@gmail.com> on 2022/01/14 03:19:33 UTC
Should lookups be split out or otherwise disabled by default?
For the extra paranoid users and users who already use some other method of generating config files (e.g., using the ConfigurationBuilder DSL which already supports arbitrary Java code), it seems like a useful feature to make lookups an opt-in feature. What do you all think? Any splitting from core would need to be done for 3.x, though we can add @RequiredProperty annotations to StrLookup plugins in 2.x to make a similar change.
--
Matt Sicker
Re: Should lookups be split out or otherwise disabled by default?
Posted by Gary Gregory <ga...@gmail.com>.
For the apps I work on, I don't see how to write configurations without
lookups, so it won't bring anything of value for me. For others, who knows.
The only value I see for separating anything in another module is to keep
log4j-core on java.base only.
Gary
On Thu, Jan 13, 2022, 22:19 Matt Sicker <bo...@gmail.com> wrote:
> For the extra paranoid users and users who already use some other method
> of generating config files (e.g., using the ConfigurationBuilder DSL which
> already supports arbitrary Java code), it seems like a useful feature to
> make lookups an opt-in feature. What do you all think? Any splitting from
> core would need to be done for 3.x, though we can add @RequiredProperty
> annotations to StrLookup plugins in 2.x to make a similar change.
> --
> Matt Sicker
>
>
Re: Should lookups be split out or otherwise disabled by default?
Posted by Matt Sicker <bo...@gmail.com>.
I think that depends on how you use Spring. My Spring app is deployed via Kubernetes where I can configure environment variables and config files to attach to each service. All my relevant data I might normally look up through Spring is exposed in multiple ways.
—
Matt Sicker
> On Jan 14, 2022, at 06:06, Apache <ra...@dslextreme.com> wrote:
>
> The answer is - it depends. Although we might consider using the properties proposal I made in master many of the lookups should default to being enabled or enabled under a condition. For example, the spring lookup only works when spring boot is present. It would be stupid for it not to be enabled when it is a spring boot app.
>
> Ralph
>
>> On Jan 13, 2022, at 8:19 PM, Matt Sicker <bo...@gmail.com> wrote:
>>
>> For the extra paranoid users and users who already use some other method of generating config files (e.g., using the ConfigurationBuilder DSL which already supports arbitrary Java code), it seems like a useful feature to make lookups an opt-in feature. What do you all think? Any splitting from core would need to be done for 3.x, though we can add @RequiredProperty annotations to StrLookup plugins in 2.x to make a similar change.
>> --
>> Matt Sicker
>>
>
Re: Should lookups be split out or otherwise disabled by default?
Posted by Apache <ra...@dslextreme.com>.
The answer is - it depends. Although we might consider using the properties proposal I made in master many of the lookups should default to being enabled or enabled under a condition. For example, the spring lookup only works when spring boot is present. It would be stupid for it not to be enabled when it is a spring boot app.
Ralph
> On Jan 13, 2022, at 8:19 PM, Matt Sicker <bo...@gmail.com> wrote:
>
> For the extra paranoid users and users who already use some other method of generating config files (e.g., using the ConfigurationBuilder DSL which already supports arbitrary Java code), it seems like a useful feature to make lookups an opt-in feature. What do you all think? Any splitting from core would need to be done for 3.x, though we can add @RequiredProperty annotations to StrLookup plugins in 2.x to make a similar change.
> --
> Matt Sicker
>