You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "harshithasudhakar (via GitHub)" <gi...@apache.org> on 2023/04/06 18:31:59 UTC
[GitHub] [eventmesh] harshithasudhakar opened a new pull request, #3640: [ISSUE #3411]Do some code optimization[ReplyMessageProcessor]
harshithasudhakar opened a new pull request, #3640:
URL: https://github.com/apache/eventmesh/pull/3640
Fixes #3411
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*
### Modifications
Changed "public" to "private static final" in the lines 63,65,67. And changed "private" to "private final" in line 69.
### Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on a diff in pull request #3640: [ISSUE #3411]Do some code optimization[ReplyMessageProcessor]
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on code in PR #3640:
URL: https://github.com/apache/eventmesh/pull/3640#discussion_r1160402383
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/ReplyMessageProcessor.java:
##########
@@ -78,7 +78,7 @@ public void processRequest(ChannelHandlerContext ctx, AsyncContext<HttpCommand>
String localAddress = IPUtils.getLocalAddress();
Review Comment:
Add this line of code.
final String channelRemoteAddr = RemotingHelper.parseChannelRemoteAddr(ctx.channel());
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #3411]Do some code optimization[ReplyMessageProcessor] (eventmesh)
Posted by "harshithasudhakar (via GitHub)" <gi...@apache.org>.
harshithasudhakar closed pull request #3640: [ISSUE #3411]Do some code optimization[ReplyMessageProcessor]
URL: https://github.com/apache/eventmesh/pull/3640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] harshithasudhakar commented on pull request #3640: [ISSUE #3411]Do some code optimization[ReplyMessageProcessor]
Posted by "harshithasudhakar (via GitHub)" <gi...@apache.org>.
harshithasudhakar commented on PR #3640:
URL: https://github.com/apache/eventmesh/pull/3640#issuecomment-1499946723
> @harshithasudhakar This pr is a draft, can't be merged.
I've marked it for ready for preview now, and can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 commented on pull request #3640: [ISSUE #3411]Do some code optimization[ReplyMessageProcessor]
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 commented on PR #3640:
URL: https://github.com/apache/eventmesh/pull/3640#issuecomment-1499839206
@harshithasudhakar This pr is a draft, can't be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3640: [ISSUE #3411]Do some code optimization[ReplyMessageProcessor]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3640:
URL: https://github.com/apache/eventmesh/pull/3640#issuecomment-1504535618
## [Codecov](https://codecov.io/gh/apache/eventmesh/pull/3640?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3640](https://codecov.io/gh/apache/eventmesh/pull/3640?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1029e03) into [master](https://codecov.io/gh/apache/eventmesh/commit/7f005243389d5c6a7942a35bbf6c5eb306cd9f01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7f00524) will **decrease** coverage by `0.02%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1029e03 differs from pull request most recent head 09ad721. Consider uploading reports for the commit 09ad721 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3640 +/- ##
============================================
- Coverage 13.76% 13.74% -0.02%
Complexity 1291 1291
============================================
Files 571 571
Lines 29239 29235 -4
Branches 2885 2884 -1
============================================
- Hits 4024 4018 -6
Misses 24841 24841
- Partials 374 376 +2
```
| [Impacted Files](https://codecov.io/gh/apache/eventmesh/pull/3640?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...protocol/http/processor/ReplyMessageProcessor.java](https://codecov.io/gh/apache/eventmesh/pull/3640?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvUmVwbHlNZXNzYWdlUHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
... and [8 files with indirect coverage changes](https://codecov.io/gh/apache/eventmesh/pull/3640/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org