os-windows/6838: Errors not reported from mod_so dll load problems on windows

[Kelly Campbell <ca...@channelpoint.com>]

>Number:         6838
>Category:       os-windows
>Synopsis:       Errors not reported from mod_so dll load problems on windows
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Mon Nov 13 16:00:01 PST 2000
>Closed-Date:
>Last-Modified:
>Originator:     camk@channelpoint.com
>Release:        1.3.14
>Organization:
apache
>Environment:
Windows 2000, and NT
>Description:
The error message given when a DLL can't load is insufficient.

Here's the fix: remove the "- len" in the last line of this code snippet

in util_win32.c

API_EXPORT(const char *) ap_os_dso_error(void)
{
    int len, nErrorCode;
    static char errstr[120];
    /* This is -not- threadsafe code, but it's about the best we can do.
     * mostly a potential problem for isapi modules, since LoadModule
     * errors are handled within a single config thread.
     */
    
    nErrorCode = GetLastError();
    len = ap_snprintf(errstr, sizeof(errstr) - len, "(%d) ", nErrorCode);


len is initialized to non-zero before it's used here (e.g. -123451) causing serious issues :-)
>How-To-Repeat:

>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted:
 [In order for any reply to be added to the PR database, you need]
 [to include <ap...@Apache.Org> in the Cc line and make sure the]
 [subject line starts with the report component and number, with ]
 [or without any 'Re:' prefixes (such as "general/1098:" or      ]
 ["Re: general/1098:").  If the subject doesn't match this       ]
 [pattern, your message will be misfiled and ignored.  The       ]
 ["apbugs" address is not added to the Cc line of messages from  ]
 [the database automatically because of the potential for mail   ]
 [loops.  If you do not include this Cc, your reply may be ig-   ]
 [nored unless you are responding to an explicit request from a  ]
 [developer.  Reply only with text; DO NOT SEND ATTACHMENTS!     ]