[GitHub] williaster closed pull request #5573: [cleanup] Remove `deep-equal` npm dependency and use `_.isEqual` instead

[GitBox <gi...@apache.org>]

williaster closed pull request #5573: [cleanup] Remove `deep-equal` npm dependency and use `_.isEqual` instead
URL: https://github.com/apache/incubator-superset/pull/5573
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/package.json b/superset/assets/package.json
index a31942be9d..d66316a219 100644
--- a/superset/assets/package.json
+++ b/superset/assets/package.json
@@ -61,7 +61,6 @@
     "datamaps": "^0.5.8",
     "datatables.net-bs": "^1.10.15",
     "deck.gl": "^5.1.4",
-    "deep-equal": "^1.0.1",
     "distributions": "^1.0.0",
     "dnd-core": "^2.6.0",
     "dompurify": "^1.0.3",
diff --git a/superset/assets/src/reduxUtils.js b/superset/assets/src/reduxUtils.js
index 17fcb65897..8b1062a8ca 100644
--- a/superset/assets/src/reduxUtils.js
+++ b/superset/assets/src/reduxUtils.js
@@ -1,7 +1,7 @@
 import shortid from 'shortid';
 import { compose } from 'redux';
 import persistState from 'redux-localstorage';
-import equals from 'deep-equal';
+import { isEqual } from 'underscore';
 
 export function addToObject(state, arrKey, obj) {
   const newObject = Object.assign({}, state[arrKey]);
@@ -95,5 +95,5 @@ export function areArraysShallowEqual(arr1, arr2) {
 }
 
 export function areObjectsEqual(obj1, obj2) {
-  return equals(obj1, obj2, true);
+  return isEqual(obj1, obj2);
 }
diff --git a/superset/assets/yarn.lock b/superset/assets/yarn.lock
index c0cc04547e..669ab3a6c4 100644
--- a/superset/assets/yarn.lock
+++ b/superset/assets/yarn.lock
@@ -3420,10 +3420,6 @@ deep-eql@^3.0.0:
   dependencies:
     type-detect "^4.0.0"
 
-deep-equal@^1.0.1:
-  version "1.0.1"
-  resolved "https://registry.yarnpkg.com/deep-equal/-/deep-equal-1.0.1.tgz#f5d260292b660e084eff4cdbc9f08ad3247448b5"
-
 deep-extend@^0.6.0:
   version "0.6.0"
   resolved "https://registry.yarnpkg.com/deep-extend/-/deep-extend-0.6.0.tgz#c4fa7c95404a17a9c3e8ca7e1537312b736330ac"


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org