You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/30 13:12:21 UTC

[GitHub] [flink] tillrohrmann opened a new pull request #13030: [FLINK-18772] Disable web submission for per-job/application mode deployments

tillrohrmann opened a new pull request #13030:
URL: https://github.com/apache/flink/pull/13030


   ## What is the purpose of the change
   
   When running Flink in per-job/application mode, it will instantiate a MiniDispatcherRestEndpoint.
   This endpoint does not instantiate the web submission REST handlers. However, it still displayed
   the submit job link in the web ui. This commit changes the behaviour so that we no longer display
   this link when running Flink in per-job/application mode.
   
   ## Verifying this change
   
   Tested this feature manually.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13030: [FLINK-18772] Disable web submission for per-job/application mode deployments

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13030:
URL: https://github.com/apache/flink/pull/13030#issuecomment-666369021


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "486351be9eea9dbe9a47563753ea3ca20946eecf",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5055",
       "triggerID" : "486351be9eea9dbe9a47563753ea3ca20946eecf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 486351be9eea9dbe9a47563753ea3ca20946eecf Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5055) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13030: [FLINK-18772] Disable web submission for per-job/application mode deployments

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13030:
URL: https://github.com/apache/flink/pull/13030#issuecomment-666369021


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "486351be9eea9dbe9a47563753ea3ca20946eecf",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5055",
       "triggerID" : "486351be9eea9dbe9a47563753ea3ca20946eecf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5812c3b06d6e0ffe854594126412d853ff42d74b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5087",
       "triggerID" : "5812c3b06d6e0ffe854594126412d853ff42d74b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 486351be9eea9dbe9a47563753ea3ca20946eecf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5055) 
   * 5812c3b06d6e0ffe854594126412d853ff42d74b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5087) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13030: [FLINK-18772] Disable web submission for per-job/application mode deployments

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13030:
URL: https://github.com/apache/flink/pull/13030#issuecomment-666369021


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "486351be9eea9dbe9a47563753ea3ca20946eecf",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "486351be9eea9dbe9a47563753ea3ca20946eecf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 486351be9eea9dbe9a47563753ea3ca20946eecf UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13030: [FLINK-18772] Disable web submission for per-job/application mode deployments

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13030:
URL: https://github.com/apache/flink/pull/13030#issuecomment-666369021


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "486351be9eea9dbe9a47563753ea3ca20946eecf",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5055",
       "triggerID" : "486351be9eea9dbe9a47563753ea3ca20946eecf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5812c3b06d6e0ffe854594126412d853ff42d74b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5812c3b06d6e0ffe854594126412d853ff42d74b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 486351be9eea9dbe9a47563753ea3ca20946eecf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5055) 
   * 5812c3b06d6e0ffe854594126412d853ff42d74b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13030: [FLINK-18772] Disable web submission for per-job/application mode deployments

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13030:
URL: https://github.com/apache/flink/pull/13030#issuecomment-666369021


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "486351be9eea9dbe9a47563753ea3ca20946eecf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5055",
       "triggerID" : "486351be9eea9dbe9a47563753ea3ca20946eecf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5812c3b06d6e0ffe854594126412d853ff42d74b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5087",
       "triggerID" : "5812c3b06d6e0ffe854594126412d853ff42d74b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5812c3b06d6e0ffe854594126412d853ff42d74b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5087) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on pull request #13030: [FLINK-18772] Disable web submission for per-job/application mode deployments

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #13030:
URL: https://github.com/apache/flink/pull/13030#issuecomment-667101447


   Fair point @zentol with the automatic configuration of the `WebMonitorEndpoint`. I've updated this PR so that we have an explicit `initializeWebSubmissionHandlers` method which if it returns an empty collection of handlers will cause the disabling of the web submit job link in the UI.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann closed pull request #13030: [FLINK-18772] Disable web submission for per-job/application mode deployments

Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #13030:
URL: https://github.com/apache/flink/pull/13030


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on pull request #13030: [FLINK-18772] Disable web submission for per-job/application mode deployments

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #13030:
URL: https://github.com/apache/flink/pull/13030#issuecomment-668021245


   Thanks for the review @zentol. Merging this PR into `master`, `release-1.11` and `release-1.10`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13030: [FLINK-18772] Disable web submission for per-job/application mode deployments

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13030:
URL: https://github.com/apache/flink/pull/13030#issuecomment-666369021


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "486351be9eea9dbe9a47563753ea3ca20946eecf",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5055",
       "triggerID" : "486351be9eea9dbe9a47563753ea3ca20946eecf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 486351be9eea9dbe9a47563753ea3ca20946eecf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5055) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13030: [FLINK-18772] Disable web submission for per-job/application mode deployments

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13030:
URL: https://github.com/apache/flink/pull/13030#issuecomment-666358131


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 486351be9eea9dbe9a47563753ea3ca20946eecf (Thu Jul 30 13:16:28 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org